EmptyVersion now displays empty string. (#9016)

Daniel Jacinto · web-flow · commit b0e5d1640b89 · 2022-02-23T15:14:35.000-07:00
diff --git a/src/NuGetGallery.Core/Frameworks/NuGetFrameworkExtensions.cs b/src/NuGetGallery.Core/Frameworks/NuGetFrameworkExtensions.cs
@@ -11,6 +11,11 @@ public static class NuGetFrameworkExtensions
     {
         public static string GetBadgeVersion(this NuGetFramework framework)
         {
+            if (framework.Version == FrameworkConstants.EmptyVersion)
+            {
+                return string.Empty;
+            }
+
             var builder = new StringBuilder();
             builder.Append(framework.Version.Major);
             builder.Append(".");
diff --git a/tests/NuGetGallery.Core.Facts/Frameworks/NuGetFrameworkExtensionsFacts.cs b/tests/NuGetGallery.Core.Facts/Frameworks/NuGetFrameworkExtensionsFacts.cs
@@ -9,8 +9,10 @@ namespace NuGetGallery.Frameworks
     public class NuGetFrameworkExtensionsFacts
     {
         [Theory]
-        [InlineData("", "0.0")]
-        [InlineData("0", "0.0")]
+        [InlineData("", "")]
+        [InlineData("0", "")]
+        [InlineData("00", "")]
+        [InlineData("0.0.0.0", "")]
         [InlineData("1", "1.0")]
         [InlineData("01", "0.1")]
         [InlineData("12", "1.2")]

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,11 @@ public static class NuGetFrameworkExtensions`
`11`	`11`	`{`
`12`	`12`	`public static string GetBadgeVersion(this NuGetFramework framework)`
`13`	`13`	`{`
	`14`	`+ if (framework.Version == FrameworkConstants.EmptyVersion)`
	`15`	`+ {`
	`16`	`+ return string.Empty;`
	`17`	`+ }`
	`18`	`+`
`14`	`19`	`var builder = new StringBuilder();`
`15`	`20`	`builder.Append(framework.Version.Major);`
`16`	`21`	`builder.Append(".");`