Skip to content

Commit 4af23cf

Browse files
authored
Increase blocking time for search indexing (#9006)
1 parent f59c4c8 commit 4af23cf

2 files changed

Lines changed: 17 additions & 11 deletions

File tree

src/NuGetGallery/ViewModels/DisplayPackageViewModel.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ public class DisplayPackageViewModel : ListPackageItemViewModel
4747
public bool HasEmbeddedReadmeFile { get; set; }
4848
public PackageDependents PackageDependents { get; set; }
4949

50+
public const int NumberOfDaysToBlockIndexing = 21;
51+
5052
public bool HasNewerPrerelease
5153
{
5254
get
@@ -150,7 +152,7 @@ public bool BlockSearchEngineIndexing
150152
{
151153
get
152154
{
153-
return !Listed || !Available || (IsRecentPackagesNoIndexEnabled && TotalDaysSinceCreated < 7);
155+
return !Listed || !Available || (IsRecentPackagesNoIndexEnabled && TotalDaysSinceCreated < NumberOfDaysToBlockIndexing);
154156
}
155157
}
156158

tests/NuGetGallery.Facts/ViewModels/DisplayPackageViewModelFacts.cs

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,7 @@ public void BlocksUnavailable()
4242
}
4343

4444
[Theory]
45-
[InlineData(0, true)]
46-
[InlineData(1, true)]
47-
[InlineData(2, true)]
48-
[InlineData(3, true)]
49-
[InlineData(4, true)]
50-
[InlineData(5, true)]
51-
[InlineData(6, true)]
52-
[InlineData(7, false)]
53-
[InlineData(8, false)]
45+
[MemberData(nameof(BlockSearchEngineIndexingData))]
5446
public void BlocksNewSingleVersion(int days, bool expected)
5547
{
5648
Target.TotalDaysSinceCreated = days;
@@ -74,10 +66,22 @@ public TheBlockSearchEngineIndexingProperty()
7466
Target.Listed = true;
7567
Target.Available = true;
7668
Target.IsRecentPackagesNoIndexEnabled = true;
77-
Target.TotalDaysSinceCreated = 14;
69+
Target.TotalDaysSinceCreated = NumberOfDaysToBlockIndexing + 7;
7870
}
7971

8072
public DisplayPackageViewModel Target { get; }
73+
74+
public static IEnumerable<object[]> BlockSearchEngineIndexingData
75+
{
76+
get
77+
{
78+
for (int i = 0; i < NumberOfDaysToBlockIndexing + 5; i++)
79+
{
80+
yield return new object[] { i, i < NumberOfDaysToBlockIndexing };
81+
}
82+
}
83+
}
84+
8185
}
8286

8387
private DateTime RandomDay()

0 commit comments

Comments
 (0)