Remove the 20 years of .NET banner (#9023)

loic-sharma · web-flow · commit 70e9f4ff4161 · 2022-02-25T17:34:56.000-08:00
Addresses https://github.com/NuGet/Engineering/issues/4267
diff --git a/src/AccountDeleter/EmptyFeatureFlagService.cs b/src/AccountDeleter/EmptyFeatureFlagService.cs
@@ -86,11 +86,6 @@ public bool IsDisplayVulnerabilitiesEnabled()
             throw new NotImplementedException();
         }
 
-        public bool IsDotnet20BannerEnabled()
-        {
-            throw new NotImplementedException();
-        }
-
         public bool IsForceFlatContainerIconsEnabled()
         {
             throw new NotImplementedException();
diff --git a/src/Bootstrap/dist/css/bootstrap-theme.css b/src/Bootstrap/dist/css/bootstrap-theme.css
diff --git a/src/Bootstrap/less/theme/page-home.less b/src/Bootstrap/less/theme/page-home.less
@@ -14,67 +14,6 @@
     margin-top: 32px;
   }
 
-  .dotnet-20-banner {
-    .dotnet-20-image {
-      position: absolute;
-      top: 0;
-      left: 0;
-      height: 100%;
-      width: 100%;
-
-      img {
-        height: 100%;
-        width: 100%;
-        object-fit: cover;
-        background-color: #000;
-      }
-    }
-
-    .container {
-      .row {
-        color: white;
-
-        @media (max-width: @screen-md-max) {
-          margin-top: 48px;
-          margin-bottom: 48px;
-        }
-
-        @media (min-width: @screen-md-max) {
-          margin-top: 144px;
-          margin-bottom: 144px;
-        }
-
-        .banner-text {
-          backdrop-filter: blur(2px);
-
-          h2 {
-            margin-top: 0px;
-            font-weight: 600;
-          }
-
-          h3 {
-            margin-top: 0px;
-            font-weight: 400;
-          }
-
-          a {
-            padding: 5px 12px 5px 12px;
-            border: 1px solid white;
-            color: white;
-            font-weight: 600;
-          }
-
-          a:focus {
-            outline-color: #fff;
-            outline-style: dashed;
-            outline-width: 2px;
-            outline-offset: 3px;
-          }
-        }
-      }
-    }
-  }
-
   .what-is-nuget {
     font-size: 1.15em;
     padding-bottom: 75px;
diff --git a/src/GitHubVulnerabilities2Db/Fakes/FakeFeatureFlagService.cs b/src/GitHubVulnerabilities2Db/Fakes/FakeFeatureFlagService.cs
@@ -274,10 +274,5 @@ public bool IsRecentPackagesNoIndexEnabled()
         {
             throw new NotImplementedException();
         }
-
-        public bool IsDotnet20BannerEnabled()
-        {
-            throw new NotImplementedException();
-        }
     }
 }
diff --git a/src/NuGetGallery.Services/Configuration/FeatureFlagService.cs b/src/NuGetGallery.Services/Configuration/FeatureFlagService.cs
@@ -40,7 +40,6 @@ public class FeatureFlagService : IFeatureFlagService
         private const string GravatarProxyEnSubdomainFeatureName = GalleryPrefix + "GravatarProxyEnSubdomain";
         private const string ODataCacheDurationsFeatureName = GalleryPrefix + "ODataCacheDurations";
         private const string ShowEnable2FADialog = GalleryPrefix + "ShowEnable2FADialog";
-        private const string ShowDotnet20Banner = GalleryPrefix + "ShowDotnet20Banner";
         private const string Get2FADismissFeedback = GalleryPrefix + "Get2FADismissFeedback";
         private const string PackageRenamesFeatureName = GalleryPrefix + "PackageRenames";
         private const string PatternSetTfmHeuristicsFeatureName = GalleryPrefix + "PatternSetTfmHeuristics";
@@ -229,11 +228,6 @@ public bool IsShowEnable2FADialogEnabled()
             return _client.IsEnabled(ShowEnable2FADialog, defaultValue: false);
         }
 
-        public bool IsDotnet20BannerEnabled()
-        {
-            return _client.IsEnabled(ShowDotnet20Banner, defaultValue: false);
-        }
-
         public bool IsGet2FADismissFeedbackEnabled()
         {
             return _client.IsEnabled(Get2FADismissFeedback, defaultValue: false);
diff --git a/src/NuGetGallery.Services/Configuration/IFeatureFlagService.cs b/src/NuGetGallery.Services/Configuration/IFeatureFlagService.cs
@@ -291,11 +291,5 @@ public interface IFeatureFlagService
         /// Whether or not recent packages has no index applied to block search engine indexing.
         /// </summary>
         bool IsRecentPackagesNoIndexEnabled();
-
-        /// <summary>
-        /// Whether to show the banner announcing .NET's 20 year celebration.
-        /// </summary>
-        /// <returns></returns>
-        bool IsDotnet20BannerEnabled();
     }
 }
diff --git a/src/NuGetGallery/App_Data/Files/Content/flags.json b/src/NuGetGallery/App_Data/Files/Content/flags.json
@@ -32,7 +32,6 @@
     "NuGetGallery.ImageAllowlist": "Enabled",
     "NuGetGallery.ShowReportAbuseSafetyChanges": "Enabled",
     "NuGetGallery.ComputeTargetFramework": "Enabled",
-    "NuGetGallery.ShowDotnet20Banner": "Enabled"
   },
   "Flights": {
     "NuGetGallery.TyposquattingFlight": {
diff --git a/src/NuGetGallery/Content/gallery/img/dotnet-20-banner.svg b/src/NuGetGallery/Content/gallery/img/dotnet-20-banner.svg
diff --git a/src/NuGetGallery/Controllers/PagesController.cs b/src/NuGetGallery/Controllers/PagesController.cs
@@ -122,14 +122,12 @@ public virtual ActionResult Home()
             var externalIdentityList = ClaimsExtensions.GetExternalCredentialIdentityList(identity);
             var showEnable2FAModal = _featureFlagService.IsShowEnable2FADialogEnabled();
             var getFeedbackOnModalDismiss = _featureFlagService.IsGet2FADismissFeedbackEnabled();
-            var showDotnet20Banner = _featureFlagService.IsDotnet20BannerEnabled();
 
             return View(new GalleryHomeViewModel(
                 showTransformModal,
                 transformIntoOrganization,
                 showEnable2FAModal,
                 getFeedbackOnModalDismiss,
-                showDotnet20Banner,
                 externalIdentityList));
         }
 
diff --git a/src/NuGetGallery/NuGetGallery.csproj b/src/NuGetGallery/NuGetGallery.csproj
@@ -1351,7 +1351,6 @@
     <Content Include="Content\gallery\img\circuit-board.svg" />
     <Content Include="Content\gallery\img\default-package-icon-256x256.png" />
     <Content Include="Content\gallery\img\default-package-icon.svg" />
-    <Content Include="Content\gallery\img\dotnet-20-banner.svg" />
     <Content Include="Content\gallery\img\dotnet-foundation-42x42.png" />
     <Content Include="Content\gallery\img\dotnet-foundation.svg" />
     <Content Include="Content\gallery\img\facebook-24x24.png" />
diff --git a/src/NuGetGallery/ViewModels/GalleryHomeViewModel.cs b/src/NuGetGallery/ViewModels/GalleryHomeViewModel.cs
@@ -13,16 +13,13 @@ public class GalleryHomeViewModel
 
         public bool ShowEnable2FAModalFeatureEnabled { get; set; }
 
-        public bool ShowDotnet20Banner { get; set; }
-
         public bool GetFeedbackOnModalDismissFeatureEnabled { get; set; }
 
         public GalleryHomeViewModel() : this(
             showTransformModal: false,
             transformIntoOrganization: false,
             showEnable2FAModalFeatureEnabled: false,
             getFeedbackOnModalDismiss: false,
-            showDotnet20Banner: false,
             identity: null)
         { }
 
@@ -31,14 +28,12 @@ public GalleryHomeViewModel(
             bool transformIntoOrganization,
             bool showEnable2FAModalFeatureEnabled,
             bool getFeedbackOnModalDismiss,
-            bool showDotnet20Banner,
             string identity = null)
         {
             ShowTransformModal = showTransformModal;
             TransformIntoOrganization = transformIntoOrganization;
             ShowEnable2FAModalFeatureEnabled = showEnable2FAModalFeatureEnabled;
             GetFeedbackOnModalDismissFeatureEnabled = getFeedbackOnModalDismiss;
-            ShowDotnet20Banner = showDotnet20Banner;
             Identity = identity;
         }
     }
diff --git a/src/NuGetGallery/Views/Pages/Home.cshtml b/src/NuGetGallery/Views/Pages/Home.cshtml
@@ -74,31 +74,6 @@ else if (AskUserToEnable2FA)
         </div>
     </div>
 
-    @if (Model.ShowDotnet20Banner)
-    {
-        <div class="dotnet-20-banner">
-            <div class="dotnet-20-image">
-                <img src="~/Content/gallery/img/dotnet-20-banner.svg" aria-hidden="true" />
-            </div>
-            <div class="container">
-                <div class="row">
-                    <div class="banner-text col-md-8">
-                        <h2>20 years of .NET</h2>
-                        <h3>Tune in on February 14, 2022 to watch the broadcast.</h3>
-                        <p>
-                            We've pulled together a celebration with the community and those who influenced the growth and
-                            success of .NET to share their stories and talk about what's in store for the next version of .NET
-                            and the next 20 years.
-                        </p>
-                        <div>
-                            <a href="https://dotnet.microsoft.com?utm_source=nugetorg">Learn more</a>
-                        </div>
-                    </div>
-                </div>
-            </div>
-        </div>
-    }
-
     <div class="container text-center what-is-nuget">
         <div class="row">
             <h2>What is NuGet?</h2>
diff --git a/src/VerifyMicrosoftPackage/Fakes/FakeFeatureFlagService.cs b/src/VerifyMicrosoftPackage/Fakes/FakeFeatureFlagService.cs
@@ -118,10 +118,5 @@ public class FakeFeatureFlagService : IFeatureFlagService
         public bool IsComputeTargetFrameworkEnabled() => throw new NotImplementedException();
 
         public bool IsRecentPackagesNoIndexEnabled() => throw new NotImplementedException();
-
-        public bool IsDotnet20BannerEnabled()
-        {
-            throw new NotImplementedException();
-        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -86,11 +86,6 @@ public bool IsDisplayVulnerabilitiesEnabled()`
`86`	`86`	`throw new NotImplementedException();`
`87`	`87`	`}`
`88`	`88`
`89`		`- public bool IsDotnet20BannerEnabled()`
`90`		`- {`
`91`		`- throw new NotImplementedException();`
`92`		`- }`
`93`		`-`
`94`	`89`	`public bool IsForceFlatContainerIconsEnabled()`
`95`	`90`	`{`
`96`	`91`	`throw new NotImplementedException();`
Original file line number	Diff line number	Diff line change
`@@ -274,10 +274,5 @@ public bool IsRecentPackagesNoIndexEnabled()`
`274`	`274`	`{`
`275`	`275`	`throw new NotImplementedException();`
`276`	`276`	`}`
`277`		`-`
`278`		`- public bool IsDotnet20BannerEnabled()`
`279`		`- {`
`280`		`- throw new NotImplementedException();`
`281`		`- }`
`282`	`277`	`}`
`283`	`278`	`}`
Original file line number	Diff line number	Diff line change
`@@ -291,11 +291,5 @@ public interface IFeatureFlagService`
`291`	`291`	`/// Whether or not recent packages has no index applied to block search engine indexing.`
`292`	`292`	`/// </summary>`
`293`	`293`	`bool IsRecentPackagesNoIndexEnabled();`
`294`		`-`
`295`		`- /// <summary>`
`296`		`- /// Whether to show the banner announcing .NET's 20 year celebration.`
`297`		`- /// </summary>`
`298`		`- /// <returns></returns>`
`299`		`- bool IsDotnet20BannerEnabled();`
`300`	`294`	`}`
`301`	`295`	`}`