Add static Instance property to NullableFrameworkComparer for caching

Copilot · joelverhagen · Copilot · commit 5c08fdad1cbc · 2025-12-10T17:52:24.000Z
Co-authored-by: joelverhagen &lt;94054+joelverhagen@users.noreply.github.com&gt;
diff --git a/src/NuGetGallery/ViewModels/DependencySetsViewModel.cs b/src/NuGetGallery/ViewModels/DependencySetsViewModel.cs
@@ -49,7 +49,7 @@ public DependencySetsViewModel(IEnumerable<PackageDependency> packageDependencie
                 }
 
                 // Sort by framework using NuGetFrameworkSorter, with null frameworks (All Frameworks) first
-                var sortedGroups = frameworkGroups.OrderBy(g => g.framework, new NullableFrameworkComparer());
+                var sortedGroups = frameworkGroups.OrderBy(g => g.framework, NullableFrameworkComparer.Instance);
 
                 // Build the final dictionary with friendly names
                 foreach (var group in sortedGroups)
@@ -95,6 +95,8 @@ public DependencyViewModel(string id, string versionSpec)
 
         private class NullableFrameworkComparer : IComparer<NuGetFramework>
         {
+            public static readonly NullableFrameworkComparer Instance = new NullableFrameworkComparer();
+
             public int Compare(NuGetFramework x, NuGetFramework y)
             {
                 // Put "All Frameworks" (null) first

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public DependencySetsViewModel(IEnumerable<PackageDependency> packageDependencie`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`// Sort by framework using NuGetFrameworkSorter, with null frameworks (All Frameworks) first`
`52`		`- var sortedGroups = frameworkGroups.OrderBy(g => g.framework, new NullableFrameworkComparer());`
	`52`	`+ var sortedGroups = frameworkGroups.OrderBy(g => g.framework, NullableFrameworkComparer.Instance);`
`53`	`53`
`54`	`54`	`// Build the final dictionary with friendly names`
`55`	`55`	`foreach (var group in sortedGroups)`
`@@ -95,6 +95,8 @@ public DependencyViewModel(string id, string versionSpec)`
`95`	`95`
`96`	`96`	`private class NullableFrameworkComparer : IComparer<NuGetFramework>`
`97`	`97`	`{`
	`98`	`+ public static readonly NullableFrameworkComparer Instance = new NullableFrameworkComparer();`
	`99`	`+`
`98`	`100`	`public int Compare(NuGetFramework x, NuGetFramework y)`
`99`	`101`	`{`
`100`	`102`	`// Put "All Frameworks" (null) first`