Skip to content

Commit 2149493

Browse files
authored
[A11y] Manage members of an organization - responsive after reflowing (#8301)
* Clear Reflow * Better UI * Vertical alignment
1 parent 151e107 commit 2149493

1 file changed

Lines changed: 28 additions & 28 deletions

File tree

src/NuGetGallery/Views/Organizations/_OrganizationAccountManageMembers.cshtml

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -34,30 +34,28 @@
3434
</div>
3535
@if (Model.CanManageMemberships)
3636
{
37-
<div class="input-group col-xs-12">
37+
<form>
3838
<div class="row">
39-
<div class="col-xs-8">
40-
<input id="new-member-textbox" class="form-control" placeholder="Add existing NuGet.org user" data-bind="textInput: NewMemberUsername, submit: AddMember" aria-label="Enter username to add member" />
39+
<div class="form-group col-sm-5">
40+
<input id="new-member-textbox" class="form-control" placeholder="Add existing NuGet.org user" data-bind="textInput: NewMemberUsername, submit: AddMember" aria-label="Enter username to add member"/>
4141
</div>
42-
<div class="col-xs-3">
43-
<select class="form-control" data-bind="value: AddMemberRole, options: RoleNames" aria-labelledby="RoleNames">
44-
</select>
42+
<div class="form-group col-sm-3">
43+
<select class="form-control" data-bind="value: AddMemberRole, options: RoleNames" aria-labelledby="RoleNames"></select>
4544
</div>
46-
<div class="text-right col-xs-1">
45+
<div class="col-sm-1">
4746
<button class="btn btn-primary" type="submit" title="Add new member" aria-label="Add new member" data-bind="click: AddMember">Add</button>
4847
</div>
4948
</div>
50-
</div>
49+
</form>
5150
<div data-bind="template: 'error-container'"></div>
5251
}
5352
<div class="member-item" data-bind="foreach: Members">
5453
<hr data-bind="visible: $index()" />
5554
<div class="row">
56-
<div class="col-xs-1 hidden-xs">
57-
<img data-bind="attr: { src: GravatarUrl, title: Username }" class="owner-image" alt="gravatar"
58-
height="36" width="36">
55+
<div class="col-sm-1 hidden-xs">
56+
<img data-bind="attr: { src: GravatarUrl, title: Username }" class="owner-image" alt="gravatar" height="36" width="36">
5957
</div>
60-
<div class="col-xs-8 col-sm-7 member-column">
58+
<div class="col-xs-10 col-sm-6 member-column">
6159
<div>
6260
<a title="View Member Profile" data-bind="attr: { href: ProfileUrl }">
6361
<span data-bind="text: Username"></span>
@@ -70,31 +68,33 @@
7068
<!-- /ko -->
7169
</div>
7270
</div>
73-
<div class="col-xs-3">
74-
@if (Model.CanManageMemberships)
75-
{
76-
<select class="form-control" aria-labelledby="OrganizationViewModel.RoleNames"
77-
data-bind="value: SelectedRole, options: OrganizationViewModel.RoleNames, event: { change: ToggleIsAdmin }">
78-
</select>
79-
}
80-
else
81-
{
82-
<span data-bind="text: SelectedRole()"></span>
83-
}
84-
</div>
85-
<!-- ko if: IsCurrentUser || @(Model.CanManageMemberships ? "true" : "false") -->
86-
<div class="col-xs-1 text-right member-column">
71+
<div class="col-xs-2 col-sm-2 col-sm-push-3 member-column text-right">
72+
<!-- ko if: IsCurrentUser || @(Model.CanManageMemberships ? "true" : "false") -->
8773
<div>
8874
<span>
8975
<button class="btn-link" data-bind="click: DeleteMember, attr: { 'aria-label': 'Delete Member' }">
9076
<i class="ms-Icon ms-Icon--Cancel" aria-hidden="true"></i>
9177
</button>
9278
</span>
9379
</div>
80+
<!-- /ko -->
81+
</div>
82+
<div class="col-xs-12 col-sm-3 col-sm-pull-2 member-column">
83+
<div>
84+
@if (Model.CanManageMemberships)
85+
{
86+
<select class="form-control" aria-labelledby="OrganizationViewModel.RoleNames"
87+
data-bind="value: SelectedRole, options: OrganizationViewModel.RoleNames, event: { change: ToggleIsAdmin }">
88+
</select>
89+
}
90+
else
91+
{
92+
<span data-bind="text: SelectedRole()"></span>
93+
}
94+
</div>
9495
</div>
95-
<!-- /ko -->
9696
</div>
9797
</div>
9898
</div>
9999
</div>
100-
</script>
100+
</script>

0 commit comments

Comments
 (0)