Not using Task.Result in async context. (#8307)

Author: agr

src/NuGetGallery/Services/SqlAggregateStatsService.cs

@@ -26,9 +26,9 @@ public SqlAggregateStatsService(IAppConfiguration configuration, ISqlConnectionF
             _connectionFactory = galleryDbConnectionFactory;
         }
 
-        public Task<AggregateStats> GetAggregateStats()
+        public async Task<AggregateStats> GetAggregateStats()
         {
-            var connection = Task.Run(() => _connectionFactory.CreateAsync()).Result;
+            var connection = await _connectionFactory.CreateAsync();
             using (var dbContext = new EntitiesContext(connection, readOnly: true)) // true - set readonly but it is ignored anyway, as this class doesn't call EntitiesContext.SaveChanges()
             {
                 var database = dbContext.Database;
@@ -41,15 +41,15 @@ public Task<AggregateStats> GetAggregateStats()
                         bool hasData = reader.Read();
                         if (!hasData)
                         {
-                            return Task.FromResult(new AggregateStats());
+                            return new AggregateStats();
                         }
 
-                        return Task.FromResult(new AggregateStats
+                        return new AggregateStats
                         {
                             Downloads = reader.IsDBNull(0) ? 0 : reader.GetInt32(0),
                             UniquePackages = reader.IsDBNull(1) ? 0 : reader.GetInt32(1),
                             TotalPackages = reader.IsDBNull(2) ? 0 : reader.GetInt32(2)
-                        });
+                        };
                     }
                 }
             }