Switch file-based app integration tests to use dotnet.exe only#7316
Open
Switch file-based app integration tests to use dotnet.exe only#7316
Conversation
Migrate all 5 file-based app tests in Dotnet.Integration.Test to invoke dotnet CLI commands directly instead of calling internal NuGet APIs: - dotnet package add --file - dotnet package remove --file - dotnet package list --file - dotnet package update --file - dotnet nuget why <file> This is possible because the test SDK (10.0.300-preview from .test/dotnet) includes the companion SDK-side support (dotnet/sdk#53535). Also removes: - MSBuildLocator.RegisterMSBuildPath from the fixture (no longer needed) - GetFileBasedAppVirtualProject helper (no longer used) - TestVirtualProjectBuilder usage from integration tests - Unnecessary using directives Closes NuGet/Home#14823 Co-authored-by: Copilot <[email protected]>
dotnet-policy-service
Bot
added
the
Community
Contributor
Author
|
cc @nkolev92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Closes NuGet/Home#14823
Description
Migrate all 5 file-based app tests in Dotnet.Integration.Test to invoke dotnet CLI commands directly instead of calling internal NuGet APIs:
This is possible because the test SDK (10.0.300-preview from .test/dotnet) includes the companion SDK-side support (dotnet/sdk#53535).
Also removes:
PR Checklist