Draft
Conversation
Resolve explicit restore sources against enabled package source names from NuGet.Config before treating them as paths. Add regression coverage for nuget.exe, dotnet restore, and MSBuild restore. Co-authored-by: Copilot <[email protected]>
nkolev92
force-pushed
the
dev-nkolev92-resolveSources
branch
2 times, most recently
from
19d53e1 to
cf044d8
Compare
Co-authored-by: Copilot <[email protected]>
nkolev92
commented
Apr 22, 2026
| var workingDirectory = Path.Combine(pathContext.SolutionRoot, projectName); | ||
| var projectFile = Path.Combine(workingDirectory, $"{projectName}.csproj"); | ||
|
|
||
| _dotnetFixture.CreateDotnetNewProject(pathContext.SolutionRoot, projectName, "classlib -f netstandard2.0", testOutputHelper: _testOutputHelper); |
Agent-Logs-Url: https://github.com/NuGet/NuGet.Client/sessions/ea481c47-5687-4bf4-8f49-91dccc5d6b62 Co-authored-by: nkolev92 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#5849
Description
This change fixes restore so explicit sources provided by name in NuGet.Config are resolved correctly instead of being treated as relative file system paths.
It adds regression coverage for:
nuget.exe-Sourcedotnet restore--sourcemsbuild/p:RestoreSourcesNo docs change is needed for this bug fix.
PR Checklist