Conversation
Replaced CreateConfigurationFile with Settings.AddSource() and Settings.AddPackageSourceMapping() in 4 PMC source mapping tests to preserve SimpleTestPathContext defaults (globalPackagesFolder, etc.). Also reuse the default 'source' feed as the opensource repo where possible. Updated apex-migration skill with config gotcha learning. Co-authored-by: Copilot <[email protected]>
| [DataTestMethod] | ||
| [DynamicData(nameof(GetPackagesConfigTemplates), DynamicDataSourceType.Method)] | ||
| [Timeout(DefaultTimeout)] | ||
| public void InstallPackageForPC_PackageSourceMapping_WithWrongMappedFeed_Fails(ProjectTemplate projectTemplate) |
There was a problem hiding this comment.
@copilot This test is timing out.
as is NuGet.Tests.Apex.NuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithCorrectSourceOption_InstallsCorrectPackage
Investigate what makes these tests potentially different from other tests in this file and push a fix.
There was a problem hiding this comment.
There was a problem hiding this comment.
No. Never use completely handwritten nuget.config. It pollutes the user's global packages folder with test packages and that's not something we want.
Revert back to using the settings.
Agent-Logs-Url: https://github.com/NuGet/NuGet.Client/sessions/69387abc-7df5-4ffa-ba29-f76c06e50ea5 Co-authored-by: nkolev92 <[email protected]>
Agent-Logs-Url: https://github.com/NuGet/NuGet.Client/sessions/69387abc-7df5-4ffa-ba29-f76c06e50ea5 Co-authored-by: nkolev92 <[email protected]>
| await CommonUtility.CreateNetFrameworkPackageInSourceAsync(opensourceRepositoryPath, packageName, packageVersion, "Thisisfromopensourcerepo1.txt"); | ||
| await CommonUtility.CreateNetFrameworkPackageInSourceAsync(privateRepositoryPath, packageName, packageVersion, "Thisisfromprivaterepo1.txt"); | ||
|
|
||
| CommonUtility.CreateConfigurationFile(Path.Combine(solutionDirectory, "NuGet.config"), $@"<?xml version=""1.0"" encoding=""utf-8""?> |
There was a problem hiding this comment.
@copilot Follow the same feedback as earlier.
Do not use CommonUtility.CreateConfigurationFile in the new tests.
InstallPackageForPC_PackageSourceMapping_WithWrongMappedFeed_Fails should be fixed in the same way.
There was a problem hiding this comment.
Done in 23887cf. I removed CommonUtility.CreateConfigurationFile and switched the affected migrated tests back to SimpleTestPathContext.Settings (AddSource + AddPackageSourceMapping), including InstallPackageForPC_PackageSourceMapping_WithWrongMappedFeed_Fails.
Agent-Logs-Url: https://github.com/NuGet/NuGet.Client/sessions/b7f564ae-9619-463a-9be9-20409e7b0ecf Co-authored-by: nkolev92 <[email protected]>
Bug
Fixes: NuGet/Home#12185
Description
Migrates PowerShell E2E tests from
PackageNameSpaceTests.ps1to C# Apex tests. The feature was renamed from "PackageNameSpace" to "PackageSourceMapping", so new test names reflect the current terminology.Migration decisions
Test-PackageSourceMappingRestore-WithSingleFeed[SkipTest]. Restore-on-build test: manually writespackages.config, builds viaBuild-Solution. Can be migrated usingSolutionService.Build()in a follow-up.Test-PackageSourceMappingRestore-WithMultipleFeedsWithIdenticalPackages-RestoresCorrectPackage[SkipTest]. Same restore-on-build pattern as #1 with two feeds and content-file verification. Can be migrated usingSolutionService.Build()in a follow-up.Test-VsPackageInstallerServices-PackageSourceMappingInstall-WithSingleFeed-SucceedIVsServicesTestCase.SimpleInstallFromIVsInstaller_PackageSourceMapping_WithSingleFeedTest-VsPackageInstallerServices-PackageSourceMappingInstall-WithSingleFeed-FailsIVsServicesTestCase.SimpleInstallFromIVsInstaller_PackageSourceMapping_WithMissingMappedSource_FailsTest-VsPackageInstallerServices-PackageSourceMappingInstall-WithMultipleFeedsWithIdenticalPackages-RestoresCorrectPackageWithSpecifiedVersionIVsServicesTestCase.SimpleInstallFromIVsInstaller_PackageSourceMapping_WithMultipleFeedsWithIdenticalPackages_InstallsCorrectPackageTest-VsPackageInstallerServices-PackageSourceMappingInstall-WithMultipleFeedsWithIdenticalPackages-RestoresCorrectPackageWithLatestVersionIVsServicesTestCase.SimpleInstallLatestFromIVsInstaller_PackageSourceMapping_WithMultipleFeedsWithIdenticalPackages_InstallsCorrectPackageTest-PC-PackageSourceMappingInstall-SucceedNuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithSingleFeedTest-PC-PackageSourceMappingInstall-FailsNuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithWrongMappedFeed_FailsTest-PC-PackageSourceMappingInstall-WithCorrectSourceOption-SucceedNuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithCorrectSourceOption_InstallsCorrectPackage-Sourceto install from mapped private feed, verifies content file origin.Test-PC-PackageSourceMappingInstall-WithWrongSourceOption-FailsNuGetConsoleTestCase.InstallPackageForPC_PackageSourceMapping_WithWrongSourceOption_Fails-Sourcepoints to unmapped feed, asserts PMC error message.Test-PC-PackageSourceMappingUpdate-WithCorrectSourceOption-SucceedNuGetConsoleTestCase.UpdatePackageForPC_PackageSourceMapping_WithCorrectSourceOption_UpdatesCorrectPackageCreateCustomTestPackage(helper)File changes
NuGetConsoleTestCase.cs— 4 new PMC tests (tests 8, 9, 10, 11)IVsServicesTestCase.cs— 2 new IVs API tests (tests 4, 6)PackageNameSpaceTests.ps1— Deleted 9 functions (tests 3-11), kept tests 1-2 and helperSKILL.md— Updated Apex migration skill with learningsPR Checklist