-
Notifications
You must be signed in to change notification settings - Fork 748
[NSJ -> STJ]Migrate RepositorySignature #7299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Nigusu-Allehu
wants to merge
2
commits into
dev-feature-nsj-stj-migration
Choose a base branch
from
dev-nyenework-repo-signature-stj
base: dev-feature-nsj-stj-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
src/NuGet.Core/NuGet.Protocol/Converters/FingerprintsStjConverter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Text.Json; | ||
| using System.Text.Json.Serialization; | ||
| using NuGet.Packaging.Core; | ||
|
|
||
| namespace NuGet.Protocol.Converters | ||
| { | ||
| internal sealed class FingerprintsStjConverter : JsonConverter<Fingerprints> | ||
| { | ||
| public override Fingerprints Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) | ||
| { | ||
| if (reader.TokenType != JsonTokenType.StartObject) | ||
| { | ||
| throw new JsonException(); | ||
| } | ||
|
|
||
| var dict = new Dictionary<string, string>(); | ||
| while (reader.Read() && reader.TokenType == JsonTokenType.PropertyName) | ||
| { | ||
| string key = reader.GetString()!; | ||
| reader.Read(); | ||
| dict[key] = reader.GetString() ?? string.Empty; | ||
| } | ||
|
|
||
| return new Fingerprints(dict); | ||
| } | ||
|
|
||
| public override void Write(Utf8JsonWriter writer, Fingerprints value, JsonSerializerOptions options) | ||
| { | ||
| writer.WriteStartObject(); | ||
| foreach (KeyValuePair<string, string> kvp in value) | ||
| { | ||
| writer.WriteString(kvp.Key, kvp.Value); | ||
| } | ||
| writer.WriteEndObject(); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
src/NuGet.Core/NuGet.Protocol/Model/RepositorySignatureModel.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace NuGet.Protocol.Model | ||
| { | ||
| internal sealed class RepositorySignatureModel | ||
| { | ||
| [JsonPropertyName(JsonProperties.AllRepositorySigned)] | ||
| public bool? AllRepositorySigned { get; set; } | ||
|
|
||
| [JsonPropertyName(JsonProperties.SigningCertificates)] | ||
| public RepositoryCertificateInfo[]? SigningCertificates { get; set; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a comment every place the bang operator is used. It means that there is certainty that there is data for property and that allowing for the null case is an imposition.