Draft
Conversation
9fa5511 to
bc6f78e
Compare
bc6f78e to
7bda1ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: updating infrastructure
Description
Upgrade xunit to v3. It has some breaking changes, so the following changes were made:
ITestOutputHelperchanged, so every file that was using it needed to remove the old namespace, and if thexunitnamespace wasn't already used, add a using for that.[WPFFact]and[WPFTheory]can use xunit's, rather than needing our own definition of them.async void. There was one instance that needed to be changed toasync Task.[PlatformFact]are changed. NuGet.CommandLine.Tests also has one.Resolve_WhenPackageExists_ReturnsSucceededSdkResultin Microsoft.Build.NuGetSdkResolver.Tests's NuGetSdkResolver_Tests.cs was validating that the output contains the message about X.509 cert chain. However, that message is output when a static variable is set to false, meaning the first method to run the test will output the message and set the static to true, preventing it from outputting for any other test. The validation only worked by coincidence because xunit runs tests in a deterministic order and this happened to be the first test in the assembly that calls into the static method that checks and changes the static variable. xunit v3 changes the test run order, so the test is no longer first, and therefore no longer gets output. Given the name of the test isn't related to checking this output message, I deleted the validationIOutputTestHelperfrom a different package/assembly is a breaking change and 2. I don't know how xunit v3's analyzers are implemented, and I wanted to reduce risk of the xunit v3 analyzers causing build errors in the server team's repo if they're not using xunit v3.PR Checklist
and a linked NuGet/Home issueAdded testsN/ALink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.