Stop using ProjectGraph for static graph restore#7268
Draft
Conversation
Member
Author
Performance TestingTested static graph restore performance on OrchardCore using Three variants were tested:
Copilot says that OrchardCore is mostly or entirely single targeting projects, so it's probably not a good repo to test the "change2" build. The noop and force scenarios shows it's not easy to match MSBuild's perf, but it's around 100ms different, which is insignificant from a human perspective, but just under 4% in percentage terms. I'm not sure how it plays out in a huge repo with 1000+ projects, or when projects have a lot of multi-targeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11680
Description
When a project has a ProjectReference with SetTargetFramework, MSBuild's ProjectGraph API will only give us the one inner build, no outer build or any of the other inner builds. So, to get around it, we take "static graph"'s philosophy of building a bunch of immutable
ProjectInstanceevaluations, but we walk the graph ourselves, where we can control ignoringSetTargetFrameworkand therefore ensuring we always get the correct outer build and all inner builds.PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.N/A