-
Notifications
You must be signed in to change notification settings - Fork 748
Add install, update gate tests #7265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nigusu-Allehu
wants to merge
9
commits into
dev
Choose a base branch
from
dev-nyenework-add-gate-tests
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dec65a3
Add search, install, uninstall gate tests
Nigusu-Allehu 09ef498
Ad packagereference tests
Nigusu-Allehu 77bb359
bring back
Nigusu-Allehu b098fbd
test
Nigusu-Allehu 0995a8f
net core
Nigusu-Allehu d7afcf1
remove
Nigusu-Allehu 255c4a4
use daily
Nigusu-Allehu 2fb4bc0
Move tests to daily
Nigusu-Allehu 8cdde95
remove
Nigusu-Allehu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -568,6 +568,7 @@ public async Task SearchTopLevelAndTransitivePackagePublicFieldInInstalledTabFro | |
|
|
||
| [TestMethod] | ||
| [Timeout(DefaultTimeout)] | ||
| [TestCategory("Gate")] | ||
| public async Task InstallTopLevelPackageFromUI() | ||
| { | ||
| // Arrange | ||
|
|
@@ -598,6 +599,7 @@ public async Task InstallTopLevelPackageFromUI() | |
|
|
||
| [TestMethod] | ||
| [Timeout(DefaultTimeout)] | ||
| [TestCategory("Gate")] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly here, this tests the PM UI Top Level and Transitive Package differentiation. I don't think that's something likely to be broken by partner teams, so I don't think this is a relevant test. |
||
| public async Task UninstallTopLevelPackageFromUI() | ||
| { | ||
| // Arrange | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you pick this one?
There's an overlap in the scenario in this method and the one from the regular apex tests.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is Net core, and the other ones are packages config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this test case is from the apex daily pipeline, which is not even something we see in our CI right now. It's supposed to be additional tests.
I'm assuming there's probably a net core version of this scenario in the regular apex tests.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I missed it, but I didn't find any focused(simple install/restore) net core tests in the per commit tests. However there are PSM net core tests. Maybe we could make use of them. I will take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's surprising.
We can keep this one then for simplicity. We can always move things around I guess.
Maybe we move that test into the regular pipeline since you've already determined it's stable?