Skip to content

Update CODEOWNERS for new directory ownership#7084

Closed
ViktorHofer wants to merge 1 commit intodevfrom
ViktorHofer-patch-1
Closed

Update CODEOWNERS for new directory ownership#7084
ViktorHofer wants to merge 1 commit intodevfrom
ViktorHofer-patch-1

Conversation

@ViktorHofer
Copy link
Copy Markdown
Contributor

Add dotnet/source-build and dotnet/product-construction teams for /eng/dotnet-build/ which is the VMR entry-point. Any changes made to that folder should get reviewed by these teams.

Bug

Fixes:

Description

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

Add dotnet/source-build and dotnet/product-construction teams for /eng/dotnet-build/ which is the VMR entry-point. Any changes made to that folder should get reviewed by these teams.
@ViktorHofer ViktorHofer requested a review from a team as a code owner January 27, 2026 12:02
@ViktorHofer
Copy link
Copy Markdown
Contributor Author

@zivkan can you help with that?

image

Comment thread .github/CODEOWNERS
* @NuGet/nuget-client
* @NuGet/nuget-client-pull-request-auto-assignment

/eng/dotnet-build/ @dotnet/source-build @dotnet/product-construction
Copy link
Copy Markdown
Member

@nkolev92 nkolev92 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no cross org owners, so this doesn't work.

Either way, I don't really want ownership to block us from merging PRs. This works both ways.

Copy link
Copy Markdown
Member

@nkolev92 nkolev92 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted internally with the team.

We'll tag people from the @dotnet/source-build @dotnet/product-construction from now on if we make changes.

Looking at the history, it was the only time we've changed anything in that directory ourselves, and I don't expect to us to touch that too frequently.

Note that the file that was edited is only NuGet specific, which is why we didn't tag anyone. The description of #6867 calls it out.

@nkolev92 nkolev92 closed this Jan 27, 2026
@nkolev92 nkolev92 deleted the ViktorHofer-patch-1 branch January 27, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants