Skip to content

Ensure stable order of files in the nuget package#6963

Merged
zivkan merged 2 commits intoNuGet:devfrom
omajid:nuget-archive-deterministic-file-order
Dec 12, 2025
Merged

Ensure stable order of files in the nuget package#6963
zivkan merged 2 commits intoNuGet:devfrom
omajid:nuget-archive-deterministic-file-order

Conversation

@omajid
Copy link
Copy Markdown
Contributor

@omajid omajid commented Nov 20, 2025

Bug

Fixes: NuGet/Home#14448

Description

We can add files to the nuget package in any order. To provide more reproducibility/deterministicness, add the files in the archive in a well-defined order.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@omajid omajid requested a review from a team as a code owner November 20, 2025 21:37
@omajid omajid requested review from martinrrm and zivkan November 20, 2025 21:37
@omajid
Copy link
Copy Markdown
Contributor Author

omajid commented Nov 20, 2025

This is a retry of #6649

@dotnet-policy-service dotnet-policy-service Bot added the Community PRs created by someone not in the NuGet team label Nov 20, 2025
Comment thread test/NuGet.Core.Tests/NuGet.Packaging.Test/PackageBuilderTest.cs
@omajid omajid force-pushed the nuget-archive-deterministic-file-order branch from 0fe21c7 to 88f5b7c Compare November 24, 2025 17:39
We can add files to the nuget package in any order. To provide more
reproducibility/deterministicness, add the files in the archive in a
well-defined order.

Fixes: NuGet/Home#14448
@omajid omajid force-pushed the nuget-archive-deterministic-file-order branch from 88f5b7c to 7ae5484 Compare November 24, 2025 22:59
Comment thread src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs Outdated
@Nigusu-Allehu Nigusu-Allehu requested a review from jeffkl December 2, 2025 23:40
@zivkan zivkan enabled auto-merge (squash) December 3, 2025 03:34
@zivkan zivkan disabled auto-merge December 3, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community PRs created by someone not in the NuGet team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a deterministic order for adding files to nuget packages

4 participants