Skip to content

Stop using /WarnAsError in source-build CI #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zivkan merged 1 commit into from
Oct 17, 2025
+2 −13
Merged

Stop using /WarnAsError in source-build CI #6867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eng/dotnet-build/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ param (
[switch][Alias('nobl')]$excludeCIBinarylog,
[switch][Alias('pb')]$productBuild,
[switch]$fromVMR,
[bool]$warnAsError = $true,
[bool]$nodeReuse = $true,
[Parameter(ValueFromRemainingArguments = $true)][string[]]$properties
)
Expand Down Expand Up @@ -44,4 +43,4 @@ catch {
ExitWithExitCode 1
}

ExitWithExitCode 0
ExitWithExitCode 0
12 changes: 1 addition & 11 deletions eng/dotnet-build/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ source_build=false
product_build=false
from_vmr=false
ci=false
warn_as_error=true
node_reuse=true
binary_log=false

Expand Down Expand Up @@ -58,10 +57,6 @@ while [[ $# > 0 ]]; do
--from-vmr|--fromvmr)
from_vmr=true
;;
--warnaserror)
warn_as_error=$2
shift
;;
--nodereuse)
node_reuse=$2
shift
Expand Down Expand Up @@ -133,9 +128,4 @@ if [[ "$ci" == true ]]; then
node_reuse=false
fi

local warnaserror_switch=""
if [[ $warn_as_error == true ]]; then
warnaserror_switch="/warnaserror"
fi

"$DOTNET" msbuild /m /nologo /clp:Summary /v:$verbosity /nr:$node_reuse $warnaserror_switch /p:TreatWarningsAsErrors=$warn_as_error /p:ContinuousIntegrationBuild=$ci $bl ${dotnetArguments[@]+"${dotnetArguments[@]}"} ${args[@]+"${args[@]}"}
"$DOTNET" msbuild /m /nologo /clp:Summary /v:$verbosity /nr:$node_reuse /p:ContinuousIntegrationBuild=$ci $bl ${dotnetArguments[@]+"${dotnetArguments[@]}"} ${args[@]+"${args[@]}"}