[WIP] Refactor PackageSpecFactory to use constants for property and item names#6654
[WIP] Refactor PackageSpecFactory to use constants for property and item names#6654
Conversation
|
@copilot I still see about 30 more instances of |
|
@zivkan Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@copilot I can still see about 30 more calls to GetProperty that pass a string literal. Please have another look, and create new constants in ProjectBuildProperties and ProjectItemProperties as needed. |
|
@zivkan Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
This PR refactors the PackageSpecFactory class to use constants from ProjectBuildProperties, ProjectItems, and ProjectItemProperties instead of string literals for MSBuild property and item names. This improves maintainability and reduces duplication, following NuGet coding guidelines.
No errors were introduced by this change.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.