Replace Regex with ReadOnlySpan char check in HasNonstandardCharacters

Co-authored-by: jeffkl <[email protected]>

Author: Copilot

src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/PackageSourceTelemetry.cs

@@ -8,7 +8,7 @@
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
-using System.Text.RegularExpressions;
+
 using System.Threading;
 using System.Threading.Tasks;
 using NuGet.Common;
@@ -30,8 +30,6 @@ public sealed class PackageSourceTelemetry : IDisposable
 
         internal const string EventName = "PackageSourceDiagnostics";
 
-        private static readonly Regex s_nonstandardIdCharRegex = new Regex(@"[^A-Za-z0-9.\-]", RegexOptions.Compiled);
-
         public enum TelemetryAction
         {
             Unknown = 0,
@@ -216,7 +214,14 @@ internal static void AddNupkgCopiedData(ProtocolDiagnosticNupkgCopiedEvent ncEve
 
         private static bool HasNonstandardCharacters(string packageId)
         {
-            return s_nonstandardIdCharRegex.IsMatch(packageId);
+            foreach (char c in packageId.AsSpan())
+            {
+                if (!((c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || c == '.' || c == '-'))
+                {
+                    return true;
+                }
+            }
+            return false;
         }
 
         public void Dispose()