Rename HasNonstandardId to IdContainsNonAsciiCharacter throughout

Co-authored-by: jeffkl <[email protected]>

Author: Copilot

src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/PackageSourceTelemetry.cs

@@ -207,9 +207,9 @@ internal static void AddNupkgCopiedData(ProtocolDiagnosticNupkgCopiedEvent ncEve
                 data.NupkgCount++;
                 data.NupkgSize += ncEvent.FileSize;
 
-                if (!data.HasNonstandardId && ncEvent.PackageId != null && HasNonstandardCharacters(ncEvent.PackageId))
+                if (!data.IdContainsNonAsciiCharacter && ncEvent.PackageId != null && HasNonstandardCharacters(ncEvent.PackageId))
                 {
-                    data.HasNonstandardId = true;
+                    data.IdContainsNonAsciiCharacter = true;
                 }
             }
         }
@@ -274,7 +274,7 @@ internal static async Task<TelemetryEvent> ToTelemetryAsync(Data data, SourceRep
                 telemetry[PropertyNames.Duration.Total] = data.Resources.Values.Sum(r => r.duration.TotalMilliseconds);
                 telemetry[PropertyNames.Nupkgs.Copied] = data.NupkgCount;
                 telemetry[PropertyNames.Nupkgs.Bytes] = data.NupkgSize;
-                telemetry[PropertyNames.Nupkgs.HasNonstandardId] = data.HasNonstandardId;
+                telemetry[PropertyNames.Nupkgs.IdContainsNonAsciiCharacter] = data.IdContainsNonAsciiCharacter;
                 AddResourceProperties(telemetry, data.Resources);
 
                 if (data.Http.Requests > 0)
@@ -440,7 +440,7 @@ internal class Data
             internal HttpData Http { get; }
             internal int NupkgCount { get; set; }
             internal long NupkgSize { get; set; }
-            internal bool HasNonstandardId { get; set; }
+            internal bool IdContainsNonAsciiCharacter { get; set; }
 
             internal Data()
             {
@@ -490,7 +490,7 @@ internal static class Nupkgs
             {
                 internal const string Copied = "nupkgs.copied";
                 internal const string Bytes = "nupkgs.bytes";
-                internal const string HasNonstandardId = "nupkgs.hasnonstandard_id";
+                internal const string IdContainsNonAsciiCharacter = "nupkgs.idcontainsnonasciicharacter";
             }
 
             internal static class Resources

test/NuGet.Clients.Tests/NuGet.VisualStudio.Common.Test/Telemetry/PackageSourceTelemetryTests.cs

@@ -145,7 +145,7 @@ public void AddNupkgCopiedData_MultipleEvents_AccumulatesCorrectly()
         [InlineData("alllower")]
         [InlineData("123Numeric")]
         [InlineData("a")]
-        public void AddNupkgCopiedData_StandardPackageId_HasNonstandardIdIsFalse(string packageId)
+        public void AddNupkgCopiedData_StandardPackageId_IdContainsNonAsciiCharacterIsFalse(string packageId)
         {
             // Arrange
             var data = CreateDataDictionary(SampleSource);
@@ -156,7 +156,7 @@ public void AddNupkgCopiedData_StandardPackageId_HasNonstandardIdIsFalse(string
 
             // Assert
             var result = Assert.Single(data).Value;
-            Assert.False(result.HasNonstandardId);
+            Assert.False(result.IdContainsNonAsciiCharacter);
         }
 
         [Theory]
@@ -165,7 +165,7 @@ public void AddNupkgCopiedData_StandardPackageId_HasNonstandardIdIsFalse(string
         [InlineData("Ünïcödé")]
         [InlineData("Package Name")]
         [InlineData("package+extra")]
-        public void AddNupkgCopiedData_NonstandardPackageId_HasNonstandardIdIsTrue(string packageId)
+        public void AddNupkgCopiedData_NonstandardPackageId_IdContainsNonAsciiCharacterIsTrue(string packageId)
         {
             // Arrange
             var data = CreateDataDictionary(SampleSource);
@@ -176,11 +176,11 @@ public void AddNupkgCopiedData_NonstandardPackageId_HasNonstandardIdIsTrue(strin
 
             // Assert
             var result = Assert.Single(data).Value;
-            Assert.True(result.HasNonstandardId);
+            Assert.True(result.IdContainsNonAsciiCharacter);
         }
 
         [Fact]
-        public void AddNupkgCopiedData_MultiplePackagesOneNonstandard_HasNonstandardIdIsTrue()
+        public void AddNupkgCopiedData_MultiplePackagesOneNonstandard_IdContainsNonAsciiCharacterIsTrue()
         {
             // Arrange
             var data = CreateDataDictionary(SampleSource);
@@ -192,11 +192,11 @@ public void AddNupkgCopiedData_MultiplePackagesOneNonstandard_HasNonstandardIdIs
 
             // Assert
             var result = Assert.Single(data).Value;
-            Assert.True(result.HasNonstandardId);
+            Assert.True(result.IdContainsNonAsciiCharacter);
         }
 
         [Fact]
-        public void AddNupkgCopiedData_NullPackageId_HasNonstandardIdIsFalse()
+        public void AddNupkgCopiedData_NullPackageId_IdContainsNonAsciiCharacterIsFalse()
         {
             // Arrange
             var data = CreateDataDictionary(SampleSource);
@@ -207,7 +207,7 @@ public void AddNupkgCopiedData_NullPackageId_HasNonstandardIdIsFalse()
 
             // Assert
             var result = Assert.Single(data).Value;
-            Assert.False(result.HasNonstandardId);
+            Assert.False(result.IdContainsNonAsciiCharacter);
         }
 
         [Fact]
@@ -381,7 +381,7 @@ public async Task ToTelemetry_WithData_CreatesTelemetryProperties(string package
 
             Assert.Equal(data.NupkgCount, result[PackageSourceTelemetry.PropertyNames.Nupkgs.Copied]);
             Assert.Equal(data.NupkgSize, result[PackageSourceTelemetry.PropertyNames.Nupkgs.Bytes]);
-            Assert.Equal(data.HasNonstandardId, result[PackageSourceTelemetry.PropertyNames.Nupkgs.HasNonstandardId]);
+            Assert.Equal(data.IdContainsNonAsciiCharacter, result[PackageSourceTelemetry.PropertyNames.Nupkgs.IdContainsNonAsciiCharacter]);
 
             Assert.Equal(data.Resources.Sum(r => r.Value.count), result[PackageSourceTelemetry.PropertyNames.Resources.Calls]);
             foreach (var resource in data.Resources)