feat(l1): [2] add unary ws JSON-RPC transport

[brbrr]

No description provided.

[Copilot]

Pull request overview

Adds a WebSocket JSON-RPC transport for the L1 Ethereum client, including subscription multiplexing (unary calls + eth_subscribe notifications), plus a shared internal test server and comprehensive transport/filter tests. The PR also exposes a jsonrpc.Response type and makes jsonrpc.Error implement error to support response decoding in the new transport.

Changes:

• Introduce wsTransport with ping loop, request/reply routing, and subscription notification dispatch.
• Add internal JSON-RPC test server supporting HTTP POST and WS upgrade, plus extensive WS transport tests (including failure/race scenarios).
• Add FilterQuery JSON marshaling tailored for eth_subscribe log filters; export jsonrpc.Response and implement Error() on jsonrpc.Error.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
l1/internal/clienttest/server.go	Internal minimal JSON-RPC server for shared WS/HTTP client tests, including ping control and raw frame injection.
l1/eth/client/transport_ws.go	New WS transport implementation (dial, read/ping loops, routing, subscription lifecycle).
l1/eth/client/transport_ws_test.go	Black-box tests covering unary calls, subscriptions, malformed frames, ping behavior, and concurrency.
l1/eth/client/transport_ws_internal_test.go	White-box tests for error classification and bounded orphan tracking.
l1/eth/client/subscribe.go	Subscription implementation (wsLogSub) and subscribeLogs using the WS transport.
l1/eth/client/options.go	Client options extended for WS ping and dial timeouts + logger injection.
l1/eth/client/filter_query.go	FilterQuery with custom MarshalJSON to omit unset block range keys.
l1/eth/client/filter_query_test.go	Tests verifying FilterQuery marshaling shapes (block range omission, topics/address encoding).
jsonrpc/server.go	Export Response and add Error() string on jsonrpc.Error to make it an error (plus minor formatting).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

l1/internal/clienttest/server.go:198

• WebSocket connections are appended to ts.wsConns but never removed when the handler exits. This can cause WSConnCount() to over-report and PushNotification/PushRawFrame to attempt writes to closed conns (returning spurious errors) after clients disconnect/reconnect.

	ts.mu.Lock()
	ts.wsConns = append(ts.wsConns, conn)
	ts.mu.Unlock()
	defer func() { _ = conn.CloseNow() }()

l1/eth/client/transport_ws.go:158

• Logging the method as a ByteString is misleading here because probe.Method is already a Go string (and zap will encode ByteString differently). Prefer zap.String for clearer logs.

		t.logger.Trace(
			"drop frame with no id and no recognised method",
			zap.ByteString("method", []byte(probe.Method)),
		)

[codecov]

Codecov Report

❌ Patch coverage is 81.15183% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.28%. Comparing base (d7e2746) to head (0c0f876).

Files with missing lines	Patch %	Lines
l1/eth/client/transport_ws.go	82.51%	23 Missing and 9 partials ⚠️
l1/eth/client/options.go	50.00%	4 Missing ⚠️

Additional details and impacted files

@@                     Coverage Diff                     @@
##           feat/l1-client-enablers    #3877      +/-   ##
===========================================================
+ Coverage                    75.13%   75.28%   +0.14%     
===========================================================
  Files                          443      445       +2     
  Lines                        39974    40143     +169     
===========================================================
+ Hits                         30035    30220     +185     
+ Misses                        7855     7814      -41     
- Partials                      2084     2109      +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.