Skip to content

VIA-1007: Fix incorrect IAM#733

Merged
kieran-broomhall-nhs merged 1 commit intomainfrom
VIA-1007-Fix
May 7, 2026
Merged

VIA-1007: Fix incorrect IAM#733
kieran-broomhall-nhs merged 1 commit intomainfrom
VIA-1007-Fix

Conversation

@kieran-broomhall-nhs
Copy link
Copy Markdown
Contributor

Description

Fix incorrect IAM stopping build from completing

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copilot AI review requested due to automatic review settings May 7, 2026 13:00
@kieran-broomhall-nhs kieran-broomhall-nhs requested a review from a team as a code owner May 7, 2026 13:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the deploy IAM policy for AWS Lambda so the build can complete by granting the correct permission on the correct resource type (event source mappings).

Changes:

  • Adds lambda:DeleteEventSourceMapping to the LambdaEventSourceMapping statement scoped to event-source-mapping ARNs.
  • Removes lambda:DeleteEventSourceMapping from the general Lambda statement that is scoped to Lambda function ARNs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kieran-broomhall-nhs kieran-broomhall-nhs merged commit dd2fc20 into main May 7, 2026
39 of 40 checks passed
@kieran-broomhall-nhs kieran-broomhall-nhs deleted the VIA-1007-Fix branch May 7, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants