Made updates to code snippets and SDK reference links#14213
Made updates to code snippets and SDK reference links#14213v-nikitach wants to merge 8 commits intomainfrom
Conversation
Acrolinx ScorecardsWe currently enforce a minimum score of 80. Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:
More info about Acrolinx Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Pull request overview
This PR updates the proactive messaging documentation for Graph-based proactive app installation by refreshing the SDK reference links and replacing/expanding the code snippets (C#, Node.js) while adding a new Python snippet.
Changes:
- Updates “SDK reference” links to point to the Teams SDK proactive messaging documentation.
- Replaces the existing C# and Node.js proactive messaging snippets with Teams SDK-based examples.
- Adds a new Python proactive messaging snippet.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Harikrishnan-MSFT
left a comment
Harikrishnan-MSFT
left a comment
There was a problem hiding this comment.
Kindly review the comments on the PR and make the necessary updates.
|
|
||
| @app.on_install_add | ||
| async def handle_install(ctx): | ||
| user_id = ctx.activity.from_property.aad_object_id |
There was a problem hiding this comment.
should be ctx.activity.from_.aad_object_id
Doc Link https://microsoft.github.io/teams-sdk/python/essentials/sending-messages/proactive-messaging/
| for (const conversationReference of Object.values(conversationReferences)) { | ||
| ```python | ||
| from microsoft_teams.api import MessageActivityInput | ||
| from microsoft_teams.apps import App |
There was a problem hiding this comment.
The PR imports App but never uses it. The correct import per official docs is ActivityContext (and InstalledActivity for the typed handler). Please correct the imports.
Update -
from microsoft_teams.api import InstalledActivity, MessageActivityInput
from microsoft_teams.apps import ActivityContext
DOC Link - https://microsoft.github.io/teams-sdk/python/essentials/sending-messages/proactive-messaging/
Acrolinx ScorecardsWe currently enforce a minimum score of 80. Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:
More info about Acrolinx Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally. |
|
Learn Build status updates of commit ce1719d: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
MSFTRickyCastaneda
left a comment
MSFTRickyCastaneda
left a comment
There was a problem hiding this comment.
Looks good to me
No description provided.