Skip to content

Hook up auto reviewer enable/disable toggle #13902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstrome merged 1 commit into from
Oct 7, 2025
Merged

Hook up auto reviewer enable/disable toggle #13902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 64 additions & 52 deletions .github/workflows/Shared-AutoLabelAssign.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,104 +1056,116 @@ jobs:

}

# Auto user assignment can be disabled on repos using the $DataTableName table.
# Auto user assignment can be disabled on repos in the calling workflow.
If ($AutoAssignUsers -eq $True) {

# There's a short window between PR open and when Draft is set by the TierManagement workflow where PR reviewers could be added.
# This If statement prevents that from happening.
If (($GitHubAction -ne "opened") -and ($IsPrDraft -eq $False)) {
###################################### Auto reviewer assignment ######################################

# Get permission level of user who created the comment. Need to use .role_name instead of .permission because .permission provides only legacy values.
# .role_name provides legacy plus triage, maintain, and custom roles like write-elevated.
$UserPermission = $(Invoke-RestMethod -Method GET -Headers $GitHubHeaders -Uri $UserPermissionUrl).role_name
If ($AutoAssignReviewers -eq $True) {

# There's a short window between PR open and when Draft is set by the TierManagement workflow where PR reviewers could be added.
# This If statement prevents that from happening.
If (($GitHubAction -ne "opened") -and ($IsPrDraft -eq $False)) {

# Get permission level of user who created the comment. Need to use .role_name instead of .permission because .permission provides only legacy values.
# .role_name provides legacy plus triage, maintain, and custom roles like write-elevated.
$UserPermission = $(Invoke-RestMethod -Method GET -Headers $GitHubHeaders -Uri $UserPermissionUrl).role_name

# Only add reviewers if the submitter can't sign off on their own PR.
If ($UserPermission -eq "read") {

# Only add reviewers if the submitter can't sign off on their own PR.
If ($UserPermission -eq "read") {
# Get the service/subservice to GitHub account map
$ServiceToAccountMap = Get-ServiceGitHubAccountMappingTable
$ExpandedServiceSubServiceRows = Expand-ServiceSubServiceRows -CsvContent $ServiceToAccountMap

# Get the service/subservice to GitHub account map
$ServiceToAccountMap = Get-ServiceGitHubAccountMappingTable
$ExpandedServiceSubServiceRows = Expand-ServiceSubServiceRows -CsvContent $ServiceToAccountMap
$ReviewerArray = @()

$ReviewerArray = @()
ForEach ($File in $FileMetadataArray) {

ForEach ($File in $FileMetadataArray) {
If ($File.Service -ne $Null) {

If ($File.Service -ne $Null) {
$FileReviewers = $Null

$FileReviewers = $Null
$FileReviewers = Get-ContentLeadAccounts -DataArray $ExpandedServiceSubServiceRows -Service $File.Service -SubService $File.SubService

$FileReviewers = Get-ContentLeadAccounts -DataArray $ExpandedServiceSubServiceRows -Service $File.Service -SubService $File.SubService
If ($FileReviewers -ne $Null) {

$ReviewerArray += $FileReviewers

}

If ($FileReviewers -ne $Null) {
} Else {

$ReviewerArray += $FileReviewers
Write-Host "No service found for file $($File.FileName)."

}

} Else {

Write-Host "No service found for file $($File.FileName)."

}

}

$ReviewerArray = $ReviewerArray | Select-Object -Unique
$ReviewerArray = $ReviewerArray | Select-Object -Unique

If ($ReviewerArray.Count -gt 0) {
If ($ReviewerArray.Count -gt 0) {

Write-Host "Checking org membership."
Write-Host "Checking org membership."

$TestedReviewerAccounts = Test-OrgMembership -GitHubReviewers $ReviewerArray
$ValidatedReviewerAccounts = $TestedReviewerAccounts.keys | Where-Object { $TestedReviewerAccounts[$_] }
$TestedReviewerAccounts = Test-OrgMembership -GitHubReviewers $ReviewerArray
$ValidatedReviewerAccounts = $TestedReviewerAccounts.keys | Where-Object { $TestedReviewerAccounts[$_] }

$AtMentionedGitHubAccounts = Add-AtPrefix -GitHubReviewers $ValidatedReviewerAccounts
$AtMentionedGitHubAccounts = Add-AtPrefix -GitHubReviewers $ValidatedReviewerAccounts

If ($ValidatedReviewerAccounts.Length -gt 0) {
If ($ValidatedReviewerAccounts.Length -gt 0) {

$MissingReviewers = Compare-PRIndividualReviewers -GitHubReviewers $ValidatedReviewerAccounts
$MissingReviewers = Compare-PRIndividualReviewers -GitHubReviewers $ValidatedReviewerAccounts

If ($MissingReviewers) {

Write-Host "Additional reviewers found. Setting reviewers and posting PR comment."
If ($MissingReviewers) {

Write-Host "Additional reviewers found. Setting reviewers and posting PR comment."

$ReviewerMessage = $AtMentionedGitHubAccounts + $(Get-PrMessage "AutoLabelAssign-ContentLeadReviewNotice")

$ReviewerMessage = $AtMentionedGitHubAccounts + $(Get-PrMessage "AutoLabelAssign-ContentLeadReviewNotice")
Set-PrReviewer -PrUrl $PrUrl -GitHubReviewers $ValidatedReviewerAccounts
Set-PrConversationMessage -Message $ReviewerMessage

Set-PrReviewer -PrUrl $PrUrl -GitHubReviewers $ValidatedReviewerAccounts
Set-PrConversationMessage -Message $ReviewerMessage
} Else {

Write-Host "No additional reviewers to add. Not setting reviewers or posting PR comment."

} Else {

Write-Host "No additional reviewers to add. Not setting reviewers or posting PR comment."
}

}
} Else {

Write-Host "No valid reviewers to assign."
Write-Host $TestedReviewerAccounts

}

} Else {

Write-Host "No valid reviewers to assign."
Write-Host $TestedReviewerAccounts

Write-Host "No reviewers matched any services or subservices in PR articles."

}


} Else {
Write-Host "No reviewers matched any services or subservices in PR articles."


Write-Host "Not adding reviewer because submitter can sign off PR. User permission: $UserPermission."
}


} Else {

Write-Host "Not adding reviewer because submitter can sign off PR. User permission: $UserPermission."
Write-Host "Not adding PR reviewers. PR action: $GitHubAction. Draft state: $IsPrDraft."

}

} Else {

Write-Host "Not adding PR reviewers. PR action: $GitHubAction. Draft state: $IsPrDraft."
Write-Host "Auto reviewer assignment disabled."

}

###################################### Auto user assignment ######################################

# Don't add assignments to PRs in excluded branches listed in $ExcludedBranchList
If (!$ExcludedBranchList.Contains($TargetBranch)) {

Expand Down