Skip to content

Fix typos and add deployment note for redirect URIs#1953

Open
minvoker wants to merge 3 commits intoMicrosoftDocs:mainfrom
minvoker:patch-1
Open

Fix typos and add deployment note for redirect URIs#1953
minvoker wants to merge 3 commits intoMicrosoftDocs:mainfrom
minvoker:patch-1

Conversation

@minvoker
Copy link
Copy Markdown

  • Adds a note about updating REDIRECT_URI and POST_LOGOUT_REDIRECT_URI when deploying
  • Corrects numbered list formatting in the sign-in setup steps

Improves clarity and helps prevent common deployment misconfiguration issues.

@prmerger-automator
Copy link
Copy Markdown
Contributor

@minvoker : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit cc7b763:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • Line 0, Column 0: [Error: git-clone-failed-by-github-app] Failure to clone the repository `https://github.com/MicrosoftDocs/security-copilot-pr/` with branch `main`. This could be caused by an incorrect repository URL, repository or branch being deleted

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@v-regandowner v-regandowner requested a review from Copilot April 23, 2026 15:12
@v-regandowner
Copy link
Copy Markdown
Contributor

@cilwerner

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Node.js/Express MSAL tutorial to reduce deployment misconfiguration and improve procedural readability.

Changes:

  • Adds an IMPORTANT note reminding readers to update REDIRECT_URI and POST_LOGOUT_REDIRECT_URI when deploying.
  • Fixes a placeholder description typo/punctuation in the .env.dev setup section.
  • Adjusts the formatting of the numbered steps in the sign-in setup section.

Comment thread docs/identity-platform/tutorial-v2-nodejs-webapp-msal.md Outdated
Comment thread docs/identity-platform/tutorial-v2-nodejs-webapp-msal.md Outdated
Comment thread docs/identity-platform/tutorial-v2-nodejs-webapp-msal.md Outdated
Comment thread docs/identity-platform/tutorial-v2-nodejs-webapp-msal.md Outdated
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 7338623:

✅ Validation status: passed

File Status Preview URL Details
docs/identity-platform/tutorial-v2-nodejs-webapp-msal.md ✅Succeeded

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit b1146cb:

✅ Validation status: passed

File Status Preview URL Details
docs/identity-platform/tutorial-v2-nodejs-webapp-msal.md ✅Succeeded

For more details, please refer to the build report.

@minvoker
Copy link
Copy Markdown
Author

minvoker commented Apr 27, 2026

@cilwerner ready for review. All checks are passing.

@prmerger-automator
Copy link
Copy Markdown
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @cilwerner

@v-dirichards
Copy link
Copy Markdown
Contributor

@cilwerner Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants