Skip to content

Fixed: prevent newline on Enter in property rename#953

Open
Devesh0129 wants to merge 2 commits intodevelopfrom
851-confirming-renaming-of-property
Open

Fixed: prevent newline on Enter in property rename#953
Devesh0129 wants to merge 2 commits intodevelopfrom
851-confirming-renaming-of-property

Conversation

@Devesh0129
Copy link
Copy Markdown
Collaborator

No description provided.

@Devesh0129 Devesh0129 linked an issue Apr 21, 2026 that may be closed by this pull request
@Logende
Copy link
Copy Markdown
Collaborator

Logende commented Apr 22, 2026

The bug seems to still exist.

I have tried this branch and got this result after pressing enter after the name when editing the property name:
image

@Logende
Copy link
Copy Markdown
Collaborator

Logende commented May 3, 2026

Still the same issue for me:

image

When initiating the edit of a property name, clicking on its very last character to have the cursor behind the last character and then pressing enter, newline is created instead of an edit confirmation. @Kenichi-Endo do you notice any difference in the behavior or not? You had originally reported the issue.

@Kenichi-Endo
Copy link
Copy Markdown

@Logende I see the same issue on https://metaconfigurator.github.io/meta-configurator/schema.
When the tree is closed and I type enter after renaming, new line is added without confirming the rename.
Screenshot 2026-05-03 at 17 05 53
When the tree is open, new line is added confirming the rename.
When the cursor is in the middle of the name, a space is added confirming the rename.
Screenshot 2026-05-03 at 17 06 58

It would be nice if Enter only confirms the rename without changing the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirming renaming of property

3 participants