[stable32] fix: files list sort accessibility#7114
Merged
vitormattos merged 6 commits intostable32from Mar 5, 2026
Merged
Conversation
…ssibility improvements - Replace scoped &-icon with :deep() to reach slot content in Vue 3 - Set :size="24" on NcIconSvgWrapper to match Files app icon size - Simplify template to single NcIconSvgWrapper with computed isAscending - Add :title="name" to NcButton for tooltip and screen reader hint Signed-off-by: Vitor Mattos <[email protected]>
…n accessibility
- Import and expose filesSortingStore via setup() replacing dead local data() properties
- Fix ariaSortForMode('basename') -> ariaSortForMode('name') mismatch with button mode prop
- Return 'none' instead of null for sortable-but-inactive columns (required by ARIA spec)
- Add scope="col" to all <th> elements so screen readers associate headers with columns
Signed-off-by: Vitor Mattos <[email protected]>
Cover isAscending computed property, --active CSS class presence, and toggleSortBy delegation for active/inactive column states Signed-off-by: Vitor Mattos <[email protected]>
…eHeader Verify ascending/descending/none/null return values and corresponding aria-sort DOM attribute for sortable and non-sortable columns Signed-off-by: Vitor Mattos <[email protected]>
Upload PDF, add signer, send request, navigate to Files list sorted by Created at descending, rename to unique name, assert Ready to sign status, delete via actions menu and confirm row disappears Signed-off-by: Vitor Mattos <[email protected]>
Upload PDF, place a visible signature element, save, navigate away and return to verify the element persists, then delete it and confirm it is removed after a second round-trip Signed-off-by: Vitor Mattos <[email protected]>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #7056