[stable32] feat: vue3 typescript migration#7089
Merged
vitormattos merged 702 commits intostable32from Mar 5, 2026
Merged
Conversation
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/components/validation/SignerDetails.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit c3b6b6c) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/components/validation/SignersList.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit ab3c3ce) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/helpers/SigningActionHelper.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit bccbe20) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/helpers/certification.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 15e0436) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/helpers/isExternal.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 8e65f41) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/helpers/useIsDarkTheme.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit b7cb92d) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/mixins/isTouchDevice.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 7ced930) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/services/SigningRequirementValidator.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit e4f4f3d) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/store/filesSorting.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 99d8ab9) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/store/keyboard.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 8a16083) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/store/userconfig.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit f725a2f) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/test-types.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 5f5bf41) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/utils/fileStatus.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 2f3ae1f) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/views/CreateAccount.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 7ba0dc9) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/views/DocumentValidationLogic.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 9639b89) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/views/FileRequestFlow.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit ad5b430) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/views/Settings/LegalInformation.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 9716776) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/views/SignatureElementsManagement.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 09ef72d) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/views/SigningInvitations.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit b1d4e20) Signed-off-by: Vitor Mattos <[email protected]>
Tighten TypeScript test typing by removing explicit any usages and using safer inferred or structural types in src/tests/views/Validation.spec.ts. Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 0264cf6) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 7eeb421) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 9f28857) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit fd5f5b6) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 4768bfa) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit ad00260) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 7ae5c26) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 5137ded) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit f247efc) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 742739d) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 7b57f0f) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 1ca1ade) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 86ff721) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit ea646a0) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 696f1da) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 1af6dd2) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 29d2ebf) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit fa38f29) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 39eb0a3) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 747b4ef) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 741859a) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 818be47) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit 10000e9) Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]> (cherry picked from commit b341b57) Signed-off-by: Vitor Mattos <[email protected]>
Add global.d.ts interfaces for the NC32 sidebar API: - OCAFilesSidebarTab (tab registration shape) - OCAFilesSidebar (open/setActiveTab/registerTab/close/Tab) - OCAFilesNamespace (wraps Sidebar) - OCAGlobalNamespace extended with optional Files property Signed-off-by: Vitor Mattos <[email protected]>
…debar.registerTab
registerSidebarTab was introduced in @nextcloud/files v4 and is not
available in v3.12.x (required for NC32 compatibility).
Replace with the NC32-native OCA.Files.Sidebar API:
- Remove tagName/custom-element infrastructure (setupCustomElement)
- Register via OCA.Files.Sidebar.registerTab(new OCA.Files.Sidebar.Tab({...}))
- Tab lifecycle (mount/update/destroy) managed via Vue createApp/unmount
Signed-off-by: Vitor Mattos <[email protected]>
getSidebar() is a @nextcloud/files v4-only API, not available in v3.12.x.
Replace sidebar open calls with the NC32-compatible global:
window.OCA.Files?.Sidebar?.open(node.path)
window.OCA.Files?.Sidebar?.setActiveTab('libresign')
Signed-off-by: Vitor Mattos <[email protected]>
…ibreSignAction getSidebar() is a @nextcloud/files v4-only API, not available in v3.12.x. Replace sidebar open/setActiveTab calls in exec() and execBatch() with the NC32-compatible OCA.Files.Sidebar global, passing node.path instead of the node object (as expected by NC32's sidebar.open(path) signature). Signed-off-by: Vitor Mattos <[email protected]>
…tusInlineAction getSidebar() is a @nextcloud/files v4-only API, not available in v3.12.x. Replace sidebar open/setActiveTab calls with the NC32-compatible OCA.Files.Sidebar global, passing node.path string. Signed-off-by: Vitor Mattos <[email protected]>
…Sidebar Adapt test setup to match the NC32-compatible sidebar implementation: - Remove getSidebar() mock (no longer used) - Add window.OCA.Files.Sidebar mock with open/setActiveTab vi.fn() - Assert sidebar calls using OCA.Files.Sidebar instead of getSidebar return value Signed-off-by: Vitor Mattos <[email protected]>
Regenerated after pinning @nextcloud/files to ^3.12.0 (resolves to 3.12.2, latest NC32-compatible release) during the Vue3/TS migration backport. Signed-off-by: Vitor Mattos <[email protected]>
…tion Signed-off-by: Vitor Mattos <[email protected]>
- Remove getSidebar mock from @nextcloud/files mock (no longer used) - Add window.OCA.Files.Sidebar mock in main beforeEach - Add path property to exec test nodes (sidebar.open requires a path string) - Update exec assertions: open(node.path) instead of open(node, 'libresign') - Update execBatch window.OCA setups to include Files.Sidebar mock Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
backport/6993/stable32
branch
from
e04a057 to
d701504
Compare
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6993