fix: draw signature tab accessibility#7058
Merged
vitormattos merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
…gnature type tabs NcButton elements inside role="tablist" were using aria-pressed which causes screen readers to announce them as toggle buttons instead of tabs. Screen readers rely on role="tab" + aria-selected to announce tab position (e.g. "Draw, tab 1 of 3") and to enable arrow-key navigation between tabs. Signed-off-by: Vitor Mattos <[email protected]>
Before signing, verify the three tabs (Draw, Text, Upload) are reachable by role="tab", that the active tab has aria-selected="true" and the inactive ones have aria-selected="false", and that switching tabs updates the selected state correctly. Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable33 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Member
Author
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.