fix: a11y improvements#7051
Merged
vitormattos merged 10 commits intomainfrom Mar 2, 2026
Merged
Conversation
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
… hint Add getPageAriaLabel callback prop to PDFElements which generates context-aware aria-labels for each page overlay. Labels vary by: - single vs multi-document envelope (includes doc name and number) - adding mode vs read-only (includes 'Press Enter or Space' hint) Unit tests cover all four combinations. Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Adds an alt prop with a translatable default ('Signature preview')
so consumers can pass context-specific descriptions while keeping
a sensible fallback for screen readers.
Signed-off-by: Vitor Mattos <[email protected]>
…ons modal - Add sr-only aria-live='polite' region that announces 'Select a signer to set their signature position' when no signer is selected - Add aria-label to NcChip with document status for screen readers - Wrap instruction text in <span> to prevent it leaking into the Cancel button's accessible name Signed-off-by: Vitor Mattos <[email protected]>
…igner
- Add signerLinkAriaLabel computed to NcListItem so screen readers
announce 'Edit signer {name}' or 'Signer {name} (already signed)'
- Add aria-hidden to NcAvatar to prevent initials leaking into the
accessible name (already conveyed by linkAriaLabel)
- Add aria-label to identification method and status NcChips
- Add sr-only span for disabled tooltip text
- Add aria-disabled to the list item when signer or method is disabled
Signed-off-by: Vitor Mattos <[email protected]>
…e action labels
- Add role='button', tabindex=0 and keydown handlers to .no-signatures
div so keyboard users can activate it to start editing
- Use translatable t('libresign', 'Delete {type}') and t('libresign',
'Edit {type}') in action button labels
- Pass :alt with 'Current {type}' to PreviewSignature for context
Signed-off-by: Vitor Mattos <[email protected]>
Adds aria-label='PDF document to sign' to the PdfEditor component so screen readers and Playwright tests can locate and scope within the PDF viewer region in the signing view. Signed-off-by: Vitor Mattos <[email protected]>
Full E2E test covering the complete self-signing flow: - Upload PDF via URL - Add signer by account with drawn signature method - Place signature position on PDF canvas using hover/rAF sync - Request and send the document - Assert signature position box is visible in signing screen - Draw signature, save and confirm Uses semantic locators throughout (getByRole, getByLabel, getByPlaceholder) to validate accessibility at each step. Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable33 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Member
Author
|
/backport to stable32 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.