[stable33] feat: vue3 typescript migration

.devcontainer/setup.sh

@@ -12,6 +12,7 @@
 git config --global --add safe.directory /var/www/html
 git config --global --add safe.directory /var/www/html/apps-extra/libresign
 cd /var/www/html/apps-extra/libresign
+git submodule update --init --recursive
 if [[ ! -d "vendor" ]]; then
 	composer install
 fi

.github/copilot-instructions.md

@@ -163,7 +163,7 @@ The second example is clear without comments because the method names describe e
 - **Db**: `OCA\Libresign\Db\*` - Entities extend `Entity`, Mappers extend `QBMapper`
 
 ### Frontend Architecture
-- **Vue 2** with Composition API patterns via `@vueuse/core`
+- **Vue 3** with Composition API patterns via `@vueuse/core`
 - **Pinia stores** for state (not Vuex)
 - **Router**: `src/router/router.js` defines SPA routes
 - **OpenAPI integration**: TypeScript types generated from OpenAPI spec via `npm run typescript:generate`

.github/workflows/lint-typescript.yml

@@ -0,0 +1,100 @@
+# This workflow is provided via the organization template repository
+#
+# https://github.com/nextcloud/.github
+# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
+#
+# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
+# SPDX-License-Identifier: MIT
+
+name: Type checking
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+      - master
+      - stable*
+
+permissions:
+  contents: read
+
+concurrency:
+  group: lint-typescript-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  changes:
+    runs-on: ubuntu-latest-low
+    permissions:
+      contents: read
+      pull-requests: read
+
+    outputs:
+      src: ${{ steps.changes.outputs.src}}
+
+    steps:
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+        id: changes
+        continue-on-error: true
+        with:
+          filters: |
+            src:
+              - '.github/workflows/lint-typescript.yml'
+              - 'package.json'
+              - 'package-lock.json'
+              - 'tsconfig.json'
+              - '**.ts'
+              - '**.vue'
+
+  test:
+    runs-on: ubuntu-latest
+
+    needs: changes
+    if: needs.changes.outputs.src != 'false'
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          persist-credentials: false
+
+      - name: Read package.json node and npm engines version
+        uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
+        id: versions
+        with:
+          fallbackNode: '^24'
+          fallbackNpm: '^11.3'
+
+      - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
+        with:
+          node-version: ${{ steps.versions.outputs.nodeVersion }}
+
+      - name: Set up npm ${{ steps.versions.outputs.npmVersion }}
+        run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
+
+      - name: Install dependencies
+        env:
+          CYPRESS_INSTALL_BINARY: 0
+        run: |
+          npm ci
+
+      - name: Check types
+        run: |
+          npm run --if-present check-types
+          npm run --if-present ts:check
+
+  summary:
+    permissions:
+      contents: none
+    runs-on: ubuntu-latest-low
+    needs: [changes, test]
+
+    if: always()
+
+    name: typescript-summary
+
+    steps:
+      - name: Summary status
+        run: if ${{ needs.changes.outputs.src != 'false' && needs.test.result != 'success' }}; then exit 1; fi

.gitignore

@@ -11,6 +11,7 @@
 /tests/integration/vendor
 /tests/integration/output
 /js/
+/css/
 /build/
 node_modules/
 /.php-cs-fixer.cache
@@ -20,4 +21,4 @@ node_modules/
 /appinfo/install-*.json
 /lib/Vendor/
 /coverage
-
+/dist/

lib/Controller/IdentifyController.php

@@ -19,28 +19,23 @@
 use OCA\Libresign\Service\Identify\ResultFilter;
 use OCA\Libresign\Service\Identify\ResultFormatter;
 use OCA\Libresign\Service\Identify\SearchNormalizer;
+use OCA\Libresign\Service\Identify\ShareTypeResolver;
 use OCA\Libresign\Service\Identify\SignerSearchContext;
-use OCA\Libresign\Service\IdentifyMethod\Account;
-use OCA\Libresign\Service\IdentifyMethod\Email;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\ApiRoute;
 use OCP\AppFramework\Http\Attribute\NoAdminRequired;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\Collaboration\Collaborators\ISearch;
 use OCP\IRequest;
-use OCP\Share\IShare;
 
 /**
  * @psalm-import-type LibresignIdentifyAccount from ResponseDefinitions
  */
 class IdentifyController extends AEnvironmentAwareController {
-	private const PHONE_METHODS = ['whatsapp', 'sms', 'telegram', 'signal'];
-
 	public function __construct(
 		IRequest $request,
 		private ISearch $collaboratorSearch,
-		private Email $identifyEmailMethod,
-		private Account $identifyAccountMethod,
+		private ShareTypeResolver $shareTypeResolver,
 		private SearchNormalizer $searchNormalizer,
 		private SignerSearchContext $signerSearchContext,
 		private ResultFilter $resultFilter,
@@ -76,7 +71,7 @@ public function search(string $search = '', string $method = '', int $page = 1,
 			return new DataResponse([]);
 		}
 
-		$shareTypes = $this->getShareTypes();
+		$shareTypes = $this->shareTypeResolver->resolve($method);
 		$offset = $limit * ($page - 1);
 
 		$this->signerSearchContext->set($method, $search, $rawSearch);
@@ -112,21 +107,4 @@ private function registerPlugin(): void {
 		$refProperty->setValue($this->collaboratorSearch, $plugins);
 	}
 
-	private function getShareTypes(): array {
-		$shareTypes = [];
-		$settings = $this->identifyEmailMethod->getSettings();
-		if ($settings['enabled']) {
-			$shareTypes[] = IShare::TYPE_EMAIL;
-		}
-		$settings = $this->identifyAccountMethod->getSettings();
-		if ($settings['enabled']) {
-			$shareTypes[] = IShare::TYPE_USER;
-		}
-
-		$shareTypes[] = SignerPlugin::TYPE_SIGNER;
-		$shareTypes[] = AccountPhonePlugin::TYPE_SIGNER_ACCOUNT_PHONE;
-		$shareTypes[] = ContactPhonePlugin::TYPE_SIGNER_CONTACT_PHONE;
-		$shareTypes[] = ManualPhonePlugin::TYPE_SIGNER_MANUAL_PHONE;
-		return $shareTypes;
-	}
 }

lib/Controller/PageController.php

@@ -111,6 +111,7 @@ public function index(): TemplateResponse {
 		$this->initialState->provideInitialState('legal_information', $this->appConfig->getValueString(Application::APP_ID, 'legal_information'));
 
 		Util::addScript(Application::APP_ID, 'libresign-main');
+		Util::addStyle(Application::APP_ID, 'libresign-main');
 
 		if (class_exists(LoadViewer::class)) {
 			$this->eventDispatcher->dispatchTyped(new LoadViewer());
@@ -156,6 +157,7 @@ public function indexF(): TemplateResponse {
 	#[FrontpageRoute(verb: 'GET', url: '/f/incomplete')]
 	public function incomplete(): TemplateResponse {
 		Util::addScript(Application::APP_ID, 'libresign-main');
+		Util::addStyle(Application::APP_ID, 'libresign-main');
 		$response = new TemplateResponse(Application::APP_ID, 'main');
 		return $response;
 	}
@@ -172,6 +174,7 @@ public function incomplete(): TemplateResponse {
 	#[FrontpageRoute(verb: 'GET', url: '/p/incomplete')]
 	public function incompleteP(): TemplateResponse {
 		Util::addScript(Application::APP_ID, 'libresign-main');
+		Util::addStyle(Application::APP_ID, 'libresign-main');
 		$response = new TemplateResponse(Application::APP_ID, 'main', [], TemplateResponse::RENDER_AS_BASE);
 		return $response;
 	}
@@ -378,6 +381,7 @@ public function sign(string $uuid): TemplateResponse {
 		$this->initialState->provideInitialState('nodeType', $this->getFileEntity()->getNodeType());
 
 		Util::addScript(Application::APP_ID, 'libresign-external');
+		Util::addStyle(Application::APP_ID, 'libresign-external');
 		if (class_exists(LoadViewer::class)) {
 			$this->eventDispatcher->dispatchTyped(new LoadViewer());
 		}
@@ -532,6 +536,7 @@ public function validation(): TemplateResponse {
 		}
 
 		Util::addScript(Application::APP_ID, 'libresign-validation');
+		Util::addStyle(Application::APP_ID, 'libresign-validation');
 		$response = new TemplateResponse(Application::APP_ID, 'validation', [], TemplateResponse::RENDER_AS_BASE);
 
 		return $response;
@@ -580,6 +585,7 @@ public function resetPassword(): TemplateResponse {
 		);
 
 		Util::addScript(Application::APP_ID, 'libresign-main');
+		Util::addStyle(Application::APP_ID, 'libresign-main');
 		$response = new TemplateResponse(Application::APP_ID, 'reset_password');
 
 		return $response;

lib/Files/TemplateLoader.php

@@ -58,6 +58,7 @@ public function handle(Event $event): void {
 		}
 
 		Util::addScript(Application::APP_ID, 'libresign-tab');
+		Util::addStyle(Application::APP_ID, 'libresign-tab');
 		Util::addStyle(Application::APP_ID, 'icons');
 	}
 

lib/Middleware/InjectionMiddleware.php

@@ -317,6 +317,7 @@ public function afterException($controller, $methodName, \Exception $exception):
 			}
 
 			Util::addScript(Application::APP_ID, 'libresign-' . $template);
+			Util::addStyle(Application::APP_ID, 'libresign-' . $template);
 			$response = new TemplateResponse(
 				appName: Application::APP_ID,
 				templateName: $template,

lib/Service/DocMdp/ConfigService.php

@@ -24,18 +24,23 @@ public function __construct(
 	}
 
 	public function isEnabled(): bool {
-		return $this->appConfig->hasKey(Application::APP_ID, self::CONFIG_KEY_LEVEL);
+		return $this->getLevel()->isCertifying();
 	}
 
 	public function setEnabled(bool $enabled): void {
-		if (!$enabled) {
-			$this->appConfig->deleteKey(Application::APP_ID, self::CONFIG_KEY_LEVEL);
+		if ($enabled) {
+			if (!$this->getLevel()->isCertifying()) {
+				$this->setLevel(DocMdpLevel::CERTIFIED_FORM_FILLING);
+			}
+			return;
 		}
+
+		$this->setLevel(DocMdpLevel::NOT_CERTIFIED);
 	}
 
 	public function getLevel(): DocMdpLevel {
-		$level = $this->appConfig->getValueInt(Application::APP_ID, self::CONFIG_KEY_LEVEL, DocMdpLevel::NOT_CERTIFIED->value);
-		return DocMdpLevel::from($level);
+		$level = $this->appConfig->getValueInt(Application::APP_ID, self::CONFIG_KEY_LEVEL, DocMdpLevel::CERTIFIED_FORM_FILLING->value);
+		return DocMdpLevel::tryFrom($level) ?? DocMdpLevel::CERTIFIED_FORM_FILLING;
 	}
 
 	public function setLevel(DocMdpLevel $level): void {

lib/Service/File/FileContentProvider.php

@@ -32,25 +32,32 @@ public function __construct(
 	 */
 	public function getContentFromUrl(string $url): string {
 		if (!filter_var($url, FILTER_VALIDATE_URL)) {
-			throw new \Exception($this->l10n->t('Invalid URL file'));
+			throw new LibresignException($this->l10n->t('Invalid URL file'), 422);
 		}
 
 		try {
 			$response = $this->client->newClient()->get($url);
 		} catch (\Throwable) {
-			throw new \Exception($this->l10n->t('Invalid URL file'));
+			throw new LibresignException($this->l10n->t('Invalid URL file'), 422);
 		}
 
-		$mimetypeFromHeader = $response->getHeader('Content-Type');
 		$content = (string)$response->getBody();
 
 		if (!$content) {
-			throw new \Exception($this->l10n->t('Empty file'));
+			throw new LibresignException($this->l10n->t('Empty file'), 422);
+		}
+
+		$mimetypeFromHeader = $response->getHeader('Content-Type');
+		// Strip parameters like "; charset=utf-8"
+		if (str_contains($mimetypeFromHeader, ';')) {
+			$mimetypeFromHeader = trim(explode(';', $mimetypeFromHeader)[0]);
 		}
 
 		$mimeTypeFromContent = $this->mimeService->getMimeType($content);
-		if ($mimetypeFromHeader !== $mimeTypeFromContent) {
-			throw new \Exception($this->l10n->t('Invalid URL file'));
+
+		// application/octet-stream is a generic fallback — trust content detection
+		if ($mimetypeFromHeader !== 'application/octet-stream' && $mimetypeFromHeader !== $mimeTypeFromContent) {
+			throw new LibresignException($this->l10n->t('Invalid URL file'), 422);
 		}
 
 		return $content;
@@ -75,7 +82,7 @@ public function getContentFromBase64(string $base64): string {
 			$mimeTypeFromContent = $this->mimeService->getMimeType($content);
 
 			if ($mimeTypeFromType !== $mimeTypeFromContent) {
-				throw new \Exception($this->l10n->t('Invalid URL file'));
+				throw new LibresignException($this->l10n->t('Invalid URL file'), 422);
 			}
 
 			$this->mimeService->setMimeType($mimeTypeFromContent);
@@ -103,7 +110,7 @@ public function getContentFromData(array $data): string {
 			return $this->getContentFromBase64($data['file']['base64']);
 		}
 
-		throw new \Exception($this->l10n->t('No file source provided'));
+		throw new LibresignException($this->l10n->t('No file source provided'), 422);
 	}
 
 	/**