Skip to content

fix: envelope file viewer fallback #6268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 2 commits into from
Dec 30, 2025
Merged

fix: envelope file viewer fallback #6268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3014840
fix: add fallback to window.open in EnvelopeFilesList viewer
vitormattos Dec 30, 2025
39d0805
fix: optimize viewFile method in EnvelopeValidation
vitormattos Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/Components/RightSidebar/EnvelopeFilesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,19 +362,20 @@ export default {
return url.toString()
},
openFile(file) {
if (window.OCA?.Viewer !== undefined) {
const fileUrl = generateUrl('/apps/libresign/p/pdf/{uuid}', { uuid: file.uuid })
if (OCA?.Viewer !== undefined) {
const fileInfo = {
source: generateUrl('/apps/libresign/p/pdf/{uuid}', {
uuid: file.uuid,
}),
source: fileUrl,
basename: file.name,
mime: 'application/pdf',
fileid: file.nodeId,
}
window.OCA.Viewer.open({
OCA.Viewer.open({
fileInfo,
list: [fileInfo],
})
} else {
window.open(`${fileUrl}?_t=${Date.now()}`)
}
},
isSelected(fileId) {
Expand Down
3 changes: 1 addition & 2 deletions src/components/validation/EnvelopeValidation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,8 @@ export default {
return n('libresign', '{progress} of {total} document signed', '{progress} of {total} documents signed', total, { progress, total })
},
viewFile(file) {
const fileUrl = generateUrl('/apps/libresign/p/pdf/{uuid}', { uuid: file.uuid })
if (OCA?.Viewer !== undefined) {
const fileUrl = generateUrl('/apps/libresign/p/pdf/{uuid}', { uuid: file.uuid })
const fileInfo = {
source: fileUrl,
basename: file.name,
Expand All @@ -260,7 +260,6 @@ export default {
list: [fileInfo],
})
} else {
const fileUrl = generateUrl('/apps/libresign/p/pdf/{uuid}', { uuid: file.uuid })
window.open(`${fileUrl}?_t=${Date.now()}`)
}
},
Expand Down