[stable32] fix: refactor envelope signing flow and envelope status propagation#6267
Merged
vitormattos merged 1 commit intostable32from Dec 30, 2025
Merged
[stable32] fix: refactor envelope signing flow and envelope status propagation#6267vitormattos merged 1 commit intostable32from
vitormattos merged 1 commit intostable32from
Conversation
- Remove unnecessary state saving/restoration in sign() method - Extract buildEnvelopeSignRequests() for envelope-specific logic - Create getEnvelopeContext() to resolve envelope and its sign request - Fix envelope status not updating when all children are signed - Ensure envelope sign_request is marked as SIGNED with timestamp - Improve envelope resolution via parent lookup and identify method matching - Simplify sign() to use envelope context from getEnvelopeContext() - Separate concerns: getSignRequestsToSign() handles requests only - Eliminate code duplication in envelope resolution logic Fixes: Envelope remains unsigned when all child files are signed Signed-off-by: Vitor Mattos <[email protected]>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6265