[stable31] feat: cancel signature request notification#6182
Merged
vitormattos merged 16 commits intostable31from Dec 14, 2025
Merged
[stable31] feat: cancel signature request notification#6182vitormattos merged 16 commits intostable31from
vitormattos merged 16 commits intostable31from
Conversation
This event is dispatched when a signature request is canceled, allowing listeners to send notifications to the affected user. Signed-off-by: Vitor Mattos <[email protected]>
…celed When a signature request with status ABLE_TO_SIGN is deleted, dispatch the SignRequestCanceledEvent for each identify method. This allows notification and email listeners to inform users about the cancellation. Signed-off-by: Vitor Mattos <[email protected]>
…lation Creates the Activity components for the cancellation notification: - SignRequestCanceled settings class - SignRequestCanceled provider for activity stream Signed-off-by: Vitor Mattos <[email protected]>
Implements the notification handler for canceled signature requests. Sends in-app notifications to users when their signature request is canceled, respecting user activity settings preferences. Signed-off-by: Vitor Mattos <[email protected]>
Implements the notification message formatting in Notifier to display cancellation notifications with proper subject and message text. Signed-off-by: Vitor Mattos <[email protected]>
Implements email notification for canceled signature requests. Sends email to users informing them that their signature request has been canceled. Signed-off-by: Vitor Mattos <[email protected]>
Registers the cancellation event in the activity stream, allowing users to see signature request cancellations in their activity history. Signed-off-by: Vitor Mattos <[email protected]>
Registers all three listeners (Notification, Mail, and Activity) for the SignRequestCanceledEvent in the application bootstrap. Signed-off-by: Vitor Mattos <[email protected]>
Adds the SignRequestCanceled setting and provider to the activity section of info.xml, making it available in the Nextcloud activity system. Signed-off-by: Vitor Mattos <[email protected]>
Adds Behat tests covering three scenarios: 1. Deleting pending request sends cancellation notification 2. Deleting draft request does not send notification 3. Deletion removes signer from file list Signed-off-by: Vitor Mattos <[email protected]>
Changes default values for email and push notifications to false in LibresignActivitySettings, ensuring all LibreSign activity types follow the same pattern and respect user opt-in preference. Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Extracts the SignRequestCanceledEvent dispatching logic from unassociateToUser into a dedicated dispatchCancellationEventIfNeeded method for better code organization and single responsibility. Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
…ceTest The RequestSignatureService constructor was updated to require 18 parameters including IEventDispatcher, but the test was only passing 17 parameters. This commit adds the missing mock dependency to fix all failing tests. Signed-off-by: Vitor Mattos <[email protected]>
backportbot-libresign
Bot
requested a review
from vitormattos
as a code owner
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6181