feat: improve signature request confirmation#6178
Merged
vitormattos merged 2 commits intomainfrom Dec 13, 2025
Merged
Conversation
The button in the signature positions modal now always shows 'Save' instead of conditionally showing 'Send' or 'Save' based on draft status. Changes: - Button always calls save() method without changing status - Removed confirmation dialog (showConfirm) from VisibleElements - Removed request() method that was changing status to ABLE_TO_SIGN - Removed unused Send icon component import - Simplified button logic by removing isDraft condition This improves UX by making the modal's purpose clear: it's for positioning signatures, not for requesting them. Signed-off-by: Vitor Mattos <[email protected]>
Added confirmation dialogs before sending signature requests to improve user awareness and prevent accidental submissions. Changes: - Added confirmation dialog for global 'Request signatures' button - Added confirmation dialog for individual signer 'Request signature' action - Created confirmRequest() and confirmRequestSigner() methods - Added state management: showConfirmRequest, showConfirmRequestSigner, selectedSigner - Modified request() to show confirmation instead of directly executing - Modified requestSignatureForSigner() to show confirmation and store selected signer The confirmation dialogs use NcDialog with @closing event for proper closing behavior when user clicks X, ESC, or Cancel button. Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.