feat: show 'Request signatures' button only for draft signers in appropriate order#6175
Merged
vitormattos merged 1 commit intomainfrom Dec 13, 2025
Merged
Conversation
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
…opriate order The 'Request signatures' button now appears conditionally based on signing flow: - Parallel flow: Shows when any signer has DRAFT status (status === 0) - Sequential flow: Shows only when current signing order has draft signers - Finds the lowest pending order among unsigned signers - Checks if that order contains any draft signers This prevents requesting signatures from signers who aren't in their turn yet in sequential signing, while maintaining flexibility in parallel signing. Refactored logic into smaller, focused methods: - hasAnyDraftSigner: Checks for any draft signer (parallel mode) - hasSequentialDraftSigners: Orchestrates sequential mode verification - getCurrentSigningOrder: Gets current order that should sign - hasOrderDraftSigners: Checks if specific order has draft signers Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
feat/conditional-request-signatures-button
branch
from
31573f8 to
2da4eaa
Compare
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.