fix: parallel flow signer status#6172
Merged
vitormattos merged 2 commits intomainfrom Dec 13, 2025
Merged
Conversation
When file status is ABLE_TO_SIGN (1) in parallel flow, all signers should be set to ABLE_TO_SIGN regardless of individual signer status sent by frontend. This fixes the issue where signers remained in DRAFT status (0) even after clicking 'Request signatures'. The logic now: 1. Check file status DRAFT first - keep all signers as DRAFT 2. Check file status ABLE_TO_SIGN - apply flow-based logic: - Parallel: All signers get ABLE_TO_SIGN - Ordered: Only first signer gets ABLE_TO_SIGN 3. Fallback to individual signer status for other cases Resolves issue where sign_request records stayed at status 0 while libresign_file was updated to status 1. Signed-off-by: Vitor Mattos <[email protected]>
Added two unit tests to validate status determination logic: 1. testParallelFlowIgnoresSignerDraftStatusWhenFileIsAbleToSign: Validates that in parallel flow, all signers are set to ABLE_TO_SIGN when file status is ABLE_TO_SIGN, ignoring individual DRAFT status sent by frontend. 2. testOrderedFlowRespectsSigningOrderWhenFileIsAbleToSign: Validates that in ordered flow, only the first signer (order 1) gets ABLE_TO_SIGN status, while subsequent signers remain DRAFT until their turn. Also updated getService() method to accept optional SequentialSigningService parameter for testing different flows. Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.