Skip to content

fix: close sidebar when deleting the selected file#6142

Merged
vitormattos merged 1 commit intomainfrom
fix/close-sidebar-on-file-delete
Dec 11, 2025
Merged

fix: close sidebar when deleting the selected file#6142
vitormattos merged 1 commit intomainfrom
fix/close-sidebar-on-file-delete

Conversation

@vitormattos
Copy link
Copy Markdown
Member

  • Changed condition from checking 'uuid' to 'nodeId' in delete method
  • Added logic to close sidebar when the deleted file is the currently selected one
  • Simplified deleteMultiple method to rely on delete method's cleanup

This fixes the issue where the sidebar remained open after deleting the only/selected file, both when the file was just uploaded or when the page was already loaded.

- Changed condition from checking 'uuid' to 'nodeId' in delete method
- Added logic to close sidebar when the deleted file is the currently selected one
- Simplified deleteMultiple method to rely on delete method's cleanup

This fixes the issue where the sidebar remained open after deleting
the only/selected file, both when the file was just uploaded or when
the page was already loaded.

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos added this to the Next Major (33) milestone Dec 11, 2025
@vitormattos vitormattos self-assigned this Dec 11, 2025
@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Dec 11, 2025
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable31

@vitormattos vitormattos merged commit 09cf331 into main Dec 11, 2025
57 checks passed
@vitormattos vitormattos deleted the fix/close-sidebar-on-file-delete branch December 11, 2025 21:46
@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 4. to release in Roadmap Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant