Skip to content

fix: prevent signers from seeing files with DRAFT sign_request status #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 2 commits into from
Dec 11, 2025
Merged

fix: prevent signers from seeing files with DRAFT sign_request status #6139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca7339e
fix: prevent signers from seeing files with DRAFT sign_request status
vitormattos Dec 11, 2025
adc396d
test: update sequential signing test to validate DRAFT filter
vitormattos Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/Db/SignRequestMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,9 @@ private function getFilesAssociatedFilesWithMeQueryBuilder(string $userId, array
$qb->expr()->eq('f.user_id', $qb->createNamedParameter($userId)),
$qb->expr()->andX(
$qb->expr()->eq('im.identifier_key', $qb->createNamedParameter(IdentifyMethodService::IDENTIFY_ACCOUNT)),
$qb->expr()->eq('im.identifier_value', $qb->createNamedParameter($userId))
$qb->expr()->eq('im.identifier_value', $qb->createNamedParameter($userId)),
$qb->expr()->neq('f.status', $qb->createNamedParameter(File::STATUS_DRAFT)),
$qb->expr()->neq('sr.status', $qb->createNamedParameter(SignRequestStatus::DRAFT->value)),
)
];
$qb->where($qb->expr()->orX(...$or))->andWhere($qb->expr()->isNull('id.id'));
Expand Down
27 changes: 16 additions & 11 deletions tests/integration/features/sign/sequential_signing.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,26 @@ Feature: sequential-signing
| users | [{"identify":{"account":"signer1"},"signingOrder":1},{"identify":{"account":"signer2"},"signingOrder":2}] |
| name | Sequential Document |
Then the response should have a status code 200
And as user "signer2"
And sending "get" to ocs "/apps/libresign/api/v1/file/list"
And the response should have a status code 200
And fetch field "(SIGN_UUID_2)ocs.data.data.0.signers.1.sign_uuid" from previous JSON response
When sending "post" to ocs "/apps/libresign/api/v1/sign/uuid/<SIGN_UUID_2>"
| method | clickToSign |
Then the response should have a status code 422
And as user "signer1"
And sending "get" to ocs "/apps/libresign/api/v1/file/list"
And the response should have a status code 200
# Signer2 should NOT see the file yet (their sign_request is in DRAFT status)
Given as user "signer2"
When sending "get" to ocs "/apps/libresign/api/v1/file/list"
Then the response should have a status code 200
And the response should be a JSON array with the following mandatory values
| key | value |
| (jq).ocs.data.data\|length | 0 |
# Signer1 can see and sign the document
Given as user "signer1"
When sending "get" to ocs "/apps/libresign/api/v1/file/list"
Then the response should have a status code 200
And fetch field "(SIGN_UUID_1)ocs.data.data.0.signers.0.sign_uuid" from previous JSON response
When sending "post" to ocs "/apps/libresign/api/v1/sign/uuid/<SIGN_UUID_1>"
| method | clickToSign |
Then the response should have a status code 200
And as user "signer2"
# After signer1 signs, signer2 should now see the file and be able to sign
Given as user "signer2"
When sending "get" to ocs "/apps/libresign/api/v1/file/list"
Then the response should have a status code 200
And fetch field "(SIGN_UUID_2)ocs.data.data.0.signers.1.sign_uuid" from previous JSON response
When sending "post" to ocs "/apps/libresign/api/v1/sign/uuid/<SIGN_UUID_2>"
| method | clickToSign |
Then the response should have a status code 200
Loading