fix: ensure organizationalUnit is converted before engine initialization#6127
Merged
vitormattos merged 1 commit intomainfrom Dec 11, 2025
Merged
fix: ensure organizationalUnit is converted before engine initialization#6127vitormattos merged 1 commit intomainfrom
vitormattos merged 1 commit intomainfrom
Conversation
The migration was failing during upgrade to stable32 because it tried to set organizationalUnit as a string when the property expects an array. The issue occurred because addConfigPathToOpenSsl() (which calls getEngine() and triggers populateInstance()) was executed before convertRootCertOuStringToArray(). This fix reorders the method calls in preSchemaChange() to convert the OU value to an array before initializing the engine, preventing the TypeError. Fixes the error: TypeError: Cannot assign string to property OCA\Libresign\Handler\CertificateEngine\AEngineHandler::$organizationalUnit of type array Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration was failing during upgrade to stable32 because it tried to set organizationalUnit as a string when the property expects an array.
The issue occurred because addConfigPathToOpenSsl() (which calls getEngine() and triggers populateInstance()) was executed before convertRootCertOuStringToArray().
This fix reorders the method calls in preSchemaChange() to convert the OU value to an array before initializing the engine, preventing the TypeError.
Fixes the error:
TypeError: Cannot assign string to property
OCA\Libresign\Handler\CertificateEngine\AEngineHandler::$organizationalUnit of type array