fix: harden footer policy fallback

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Exception/FooterStampUnavailableException.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+/**
+ * SPDX-FileCopyrightText: 2026 LibreCode coop and contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Libresign\Exception;
+
+use RuntimeException;
+
+class FooterStampUnavailableException extends RuntimeException {
+}

lib/Handler/PdfTk/Pdf.php

@@ -9,7 +9,7 @@
 namespace OCA\Libresign\Handler\PdfTk;
 
 use OCA\Libresign\AppInfo\Application;
-use OCA\Libresign\Exception\LibresignException;
+use OCA\Libresign\Exception\FooterStampUnavailableException;
 use OCA\Libresign\Helper\JavaHelper;
 use OCA\Libresign\Vendor\mikehaertl\pdftk\Command;
 use OCA\Libresign\Vendor\mikehaertl\pdftk\Pdf as BasePdf;
@@ -45,17 +45,16 @@ public function applyStamp(string $input, string $stamp): string {
 	protected function configureCommand(): void {
 		$this->javaPath = $this->javaHelper->getJavaPath();
 		if ($this->javaPath === '') {
-			throw new RuntimeException('Java path not set.');
+			throw new FooterStampUnavailableException('Java path not set.');
 		}
 
 		$this->pdftkPath = $this->appConfig->getValueString(Application::APP_ID, 'pdftk_path');
 		if ($this->pdftkPath === '') {
-			throw new RuntimeException('PDFtk path not set.');
+			throw new FooterStampUnavailableException('PDFtk path not set.');
 		}
 
-
 		if (!file_exists($this->javaPath) || !file_exists($this->pdftkPath)) {
-			throw new LibresignException($this->l10n->t('The admin hasn\'t set up LibreSign yet, please wait.'));
+			throw new FooterStampUnavailableException($this->l10n->t('The admin hasn\'t set up LibreSign yet, please wait.'));
 		}
 
 		$cmd = sprintf('%s -jar %s', escapeshellcmd($this->javaPath), escapeshellarg($this->pdftkPath));

lib/Service/Policy/Provider/RequestSignGroups/RequestSignGroupsPolicyGuard.php

@@ -34,7 +34,7 @@ public function assertUserScopeSupported(string $policyKey): void {
 		throw new \InvalidArgumentException($this->l10n->t(self::USER_SCOPE_NOT_SUPPORTED_MESSAGE));
 	}
 
-	public function normalizeManagedValue(string $policyKey, null|bool|int|float|string $value, bool $allowNullReset = false): null|bool|int|float|string {
+	public function normalizeManagedValue(string $policyKey, mixed $value, bool $allowNullReset = false): mixed {
 		if ($policyKey !== RequestSignGroupsPolicy::KEY) {
 			return $value;
 		}

lib/Service/SignFileService.php

@@ -29,6 +29,7 @@
 use OCA\Libresign\Db\UserElementMapper;
 use OCA\Libresign\Enum\FileStatus;
 use OCA\Libresign\Events\SignedEventFactory;
+use OCA\Libresign\Exception\FooterStampUnavailableException;
 use OCA\Libresign\Exception\LibresignException;
 use OCA\Libresign\Handler\DocMdpHandler;
 use OCA\Libresign\Handler\FooterHandler;
@@ -1372,7 +1373,12 @@ protected function getPdfToSign(File $originalFile): File {
 
 			try {
 				$pdfContent = $this->pdf->applyStamp($input, $stamp);
-			} catch (RuntimeException $e) {
+			} catch (FooterStampUnavailableException $e) {
+				$this->logger->warning('Using original PDF because footer stamping is unavailable.', [
+					'exception' => $e,
+				]);
+				$pdfContent = $originalContent;
+			} catch (RuntimeException|LibresignException $e) {
 				throw new LibresignException($e->getMessage());
 			}
 		} else {

tests/php/Unit/Handler/PdfTest.php

@@ -6,7 +6,6 @@
 namespace OCA\Libresign\Tests\Unit\Handler;
 
 use OCA\Libresign\AppInfo\Application;
-use OCA\Libresign\Exception\LibresignException;
 use OCA\Libresign\Handler\PdfTk\Pdf;
 use OCA\Libresign\Helper\JavaHelper;
 use OCP\IAppConfig;
@@ -90,7 +89,7 @@ public function testInvalidDependenciesPath(): void {
 		$this->appConfig->setValueString(Application::APP_ID, 'pdftk_path', '/fake/path');
 		$pdf = $this->getInstance();
 
-		$this->expectException(LibresignException::class);
+		$this->expectException(RuntimeException::class);
 		$this->expectExceptionMessageMatches('/set up/');
 
 		$pdf->applyStamp('/tmp/input.pdf', '/tmp/stamp.pdf');