fix(policy): resolve IdentifyService constructor injection and fix unit tests

- Restore PolicyService as constructor parameter in IdentifyService
  (removed lazy Server::get() which bypassed DI mocking)
- Add getFriendlyNamesMap() to IdentifyMethodService that reads
  friendly names directly from injected instances, avoiding circular
  call chain (getSettings() -> PolicyService -> normalize() -> getSettings())
- Update IdentifyMethodsPolicyValue::normalize() to accept optional
  IdentifyMethodService for enriching identify_methods entries that
  lack friendly_name (e.g. values stored via provisioning API)
- Update IdentifyMethodsPolicyTest to inject IdentifyMethodService mock
  in constructor

This fixes the Playwright E2E tests that timed out at
getByPlaceholder(Account) because the identify_methods values set
via provisioning API did not include friendly_name, which the
frontend uses as tab label and input placeholder text.

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Service/IdentifyMethod/IdentifyService.php

@@ -133,7 +133,7 @@ public function getSavedSettings(): array {
 			return $this->savedSettings;
 		}
 
-		$resolved = $this->policyService->resolve(IdentifyMethodsPolicy::KEY)->getEffectiveValue();
+		$resolved = $this->getPolicyService()->resolve(IdentifyMethodsPolicy::KEY)->getEffectiveValue();
 		$normalized = IdentifyMethodsPolicyValue::normalize($resolved);
 		$this->savedSettings = $normalized;
 		return $this->savedSettings;

lib/Service/IdentifyMethodService.php

@@ -359,12 +359,17 @@ public function getIdentifyMethodsSettings(): array {
 		return $this->identifyMethodsSettings;
 	}
 
-	/**
-	 * Resolve UID from certificate chain data
-@@		if ($this->xmpp->isTwofactorGatewayEnabled()) {
-			$this->identifyMethodsSettings[] = $this->xmpp->getSettings();
-		}
-		return $this->identifyMethodsSettings;
+	/** @return array<string, string> */
+	public function getFriendlyNamesMap(): array {
+		return [
+			$this->account->getName() => $this->account->getFriendlyName(),
+			$this->email->getName() => $this->email->getFriendlyName(),
+			$this->signal->getName() => $this->signal->getFriendlyName(),
+			$this->sms->getName() => $this->sms->getFriendlyName(),
+			$this->telegram->getName() => $this->telegram->getFriendlyName(),
+			$this->Whatsapp->getName() => $this->Whatsapp->getFriendlyName(),
+			$this->xmpp->getName() => $this->xmpp->getFriendlyName(),
+		];
 	}
 
 	/**

lib/Service/Policy/Provider/IdentifyMethods/IdentifyMethodsPolicyValue.php

@@ -84,10 +84,8 @@ public static function normalize(mixed $rawValue, ?IdentifyMethodService $identi
 			$normalized[] = $normalizedEntry;
 		}
 
-		// Enrich friendly_name from identify method services if not present and service is available
 		if ($identifyMethodService !== null) {
-			$settings = $identifyMethodService->getIdentifyMethodsSettings();
-			$friendlyNames = array_column($settings, 'friendly_name', 'name');
+			$friendlyNames = $identifyMethodService->getFriendlyNamesMap();
 			foreach ($normalized as &$entry) {
 				if (!isset($entry['friendly_name']) && isset($entry['name'], $friendlyNames[$entry['name']])) {
 					$entry['friendly_name'] = $friendlyNames[$entry['name']];

tests/php/Unit/Service/Policy/Provider/IdentifyMethods/IdentifyMethodsPolicyTest.php

@@ -8,12 +8,21 @@
 
 namespace OCA\Libresign\Tests\Unit\Service\Policy\Provider\IdentifyMethods;
 
+use OCA\Libresign\Service\IdentifyMethodService;
 use OCA\Libresign\Service\Policy\Provider\IdentifyMethods\IdentifyMethodsPolicy;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 final class IdentifyMethodsPolicyTest extends TestCase {
+	private IdentifyMethodService&MockObject $identifyMethodService;
+
+	public function setUp(): void {
+		parent::setUp();
+		$this->identifyMethodService = $this->createMock(IdentifyMethodService::class);
+	}
+
 	public function testProviderBuildsIdentifyMethodsDefinition(): void {
-		$provider = new IdentifyMethodsPolicy();
+		$provider = new IdentifyMethodsPolicy($this->identifyMethodService);
 		$this->assertSame([IdentifyMethodsPolicy::KEY], $provider->keys());
 
 		$definition = $provider->get(IdentifyMethodsPolicy::KEY);
@@ -22,7 +31,7 @@ public function testProviderBuildsIdentifyMethodsDefinition(): void {
 	}
 
 	public function testProviderNormalizesIdentifyMethodsPayload(): void {
-		$provider = new IdentifyMethodsPolicy();
+		$provider = new IdentifyMethodsPolicy($this->identifyMethodService);
 		$definition = $provider->get(IdentifyMethodsPolicy::KEY);
 
 		$normalized = $definition->normalizeValue([