Fix std::u8string vs std::string mismatch in tool/val/val.cpp vulkan-sdk-1.4.328(.2)#6438
Open
aminiussi wants to merge 1 commit intoKhronosGroup:vulkan-sdk-1.4.328from
Open
Fix std::u8string vs std::string mismatch in tool/val/val.cpp vulkan-sdk-1.4.328(.2)#6438aminiussi wants to merge 1 commit intoKhronosGroup:vulkan-sdk-1.4.328from
aminiussi wants to merge 1 commit intoKhronosGroup:vulkan-sdk-1.4.328from
Conversation
…and std::u8string
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is the following piece of code in val.cpp:
That is, filepath_str is created but not used. It fails with C++ 20 for reasons mentioned in the source code comment.
It's been fixed in other branches but I need to use homogeneous versions for vulkan components and https://github.com/KhronosGroup/SPIRV-Headers stops at 1.4.328.1 so a fixed vulkan-sdk-1.4.328 for Tools would be nice (I download everything at config time through FetchContent for my project).
I guess it could be tagged vulkan-sdk-1.4.328.1 ?
Thx