Skip to content

Revert "Replace getproperty(::DirEntry,::Symbol) method"#61722

Open
vtjnash wants to merge 2 commits intomasterfrom
revert-60518-mh/DirEntry-path
Open

Revert "Replace getproperty(::DirEntry,::Symbol) method"#61722
vtjnash wants to merge 2 commits intomasterfrom
revert-60518-mh/DirEntry-path

Conversation

@vtjnash
Copy link
Copy Markdown
Member

@vtjnash vtjnash commented May 5, 2026

Reverts #60518

You aren't allowed to deprecate public, documented API just because you don't like it

@adienes
Copy link
Copy Markdown
Member

adienes commented May 5, 2026

DirEntry doesn't appear to be public (at least, according to Base.ispublic)

@vtjnash
Copy link
Copy Markdown
Member Author

vtjnash commented May 5, 2026

It is the API of readdirx

@KristofferC
Copy link
Copy Markdown
Member

There is only _readdirx?

@vtjnash
Copy link
Copy Markdown
Member Author

vtjnash commented May 5, 2026

Why does that have such an odd name?

@topolarity
Copy link
Copy Markdown
Member

Because it is not public

@IanButterworth
Copy link
Copy Markdown
Member

See #55333 #55358
I don't think things stalled for any good reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants