Updates from macOS testing#2003
Draft
mathomp4 wants to merge 43 commits intoJCSDA:developfrom
Draft
Conversation
# Conflicts: # repos/builtin
Collaborator
|
@mathomp4 Can you resolve the conflicts, please? It would be nice to test this + JCSDA/spack-packages#53 in CI. Thanks! |
# Conflicts: # repos/builtin
Collaborator
Author
@climbfuji I think I did this right? I had to lean on some GPT to help because it was a new git error/warning I'd never seen before (since it involved a submodule, etc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has updates needed in my testing on macOS.
One change that is "generic" to many is the change to
configs/common/modules_lmod.yamlandconfigs/common/modules_tcl.yaml, e.g.,:The reason is because CMake's FindPython and FindPython3 look at
Python_ROOT_DIRandPython3_ROOT_DIRas hints, but spack only providespython_ROOT_DIR...and CMake is case-sensitive.This also has a change to allow both older and newer FMS as GEOS (at present) only works with FMS 2024.
Dependencies
JCSDA/spack-packages#53
Issues addressed
Closes #1983
Closes #1982
Closes #1984
Applications affected
None
Systems affected
None
Testing
Checklist