Format issue number at start of release note item. Fixes #31

Author: Jake Ginnivan

src/GitReleaseNotes.Tests/IssueTrackers/GitHub/GitHubIssueTrackerTests.cs

@@ -65,6 +65,7 @@ public void CreatesReleaseNotesForClosedGitHubIssues()
             var closedIssues = _sut.GetClosedIssues(DateTimeOffset.Now.AddDays(-2));
             var onlineIssue = closedIssues.Single();
             onlineIssue.Title.ShouldBe("Issue Title");
+            onlineIssue.Id.ShouldBe("#1");
             onlineIssue.Contributors.ShouldContain(c => c.Username == "User" && c.Name == "Foo" && c.Url == "http://github.com/foo");
         }
 

src/GitReleaseNotes.Tests/ReleaseNotesGeneratorTests.AdditionalCategoriesCanBeSpecifiedOnCommandLine.approved.txt

@@ -1,3 +1,3 @@
- - Issue 1 [#1](http://github.com/org/repo/issues/1) +internal-refactoring
+ - [#1](http://github.com/org/repo/issues/1) - Issue 1 +internal-refactoring
 
 Commits: 12345678...67890123

src/GitReleaseNotes.Tests/ReleaseNotesGeneratorTests.ApproveSimpleTests.approved.txt

@@ -1,4 +1,4 @@
- - Issue 1 [#1](http://github.com/org/repo/issues/1) contributed by Foo Bar ([@foo](http://url.com/foo))
+ - [#1](http://github.com/org/repo/issues/1) - Issue 1 contributed by Foo Bar ([@foo](http://url.com/foo))
  - Issue 1
 
 Commits: 12345678...67890123

src/GitReleaseNotes.Tests/ReleaseNotesGeneratorTests.ApproveSimpleUpdateTests.approved.txt

@@ -1,4 +1,4 @@
- - Customised title for Issue 1 [#1](http://github.com/org/repo/issues/1)
- - Issue 2 [#2](http://github.com/org/repo/issues/2)
+ - [#1](http://github.com/org/repo/issues/1) - Customised title for Issue 1
+ - [#2](http://github.com/org/repo/issues/2) - Issue 2
 
 Commits: 12345678...67890123

src/GitReleaseNotes.Tests/ReleaseNotesGeneratorTests.ItemIsCategorised.approved.txt

@@ -1,3 +1,3 @@
- - Issue 1 [#1](http://github.com/org/repo/issues/1) +feature
+ - [#1](http://github.com/org/repo/issues/1) - Issue 1 +feature
 
 Commits: 12345678...67890123

src/GitReleaseNotes.Tests/ReleaseNotesGeneratorTests.LabelOfBugIsCategorisedAsFix.approved.txt

@@ -1,3 +1,3 @@
- - Issue 1 [#1](http://github.com/org/repo/issues/1) +fix
+ - [#1](http://github.com/org/repo/issues/1) - Issue 1 +fix
 
 Commits: 12345678...67890123

src/GitReleaseNotes.Tests/ReleaseNotesGeneratorTests.MultipleReleases.approved.txt

@@ -1,13 +1,13 @@
 # vNext
 
- - Issue 1 [#1](http://github.com/org/repo/issues/1) +feature
+ - [#1](http://github.com/org/repo/issues/1) - Issue 1 +feature
 
 Commits: 12345678...67890123
 
 
 # 1.2.0 (06 December 2013)
 
- - Issue 2 [#2](http://github.com/org/repo/issues/2) +feature
- - Issue 3 [#3](http://github.com/org/repo/issues/3) +fix
+ - [#2](http://github.com/org/repo/issues/2) - Issue 2 +feature
+ - [#3](http://github.com/org/repo/issues/3) - Issue 3 +fix
 
 Commits: asdsadaf...bfdsadre

src/GitReleaseNotes/IssueTrackers/GitHub/GitHubIssueTracker.cs

@@ -144,11 +144,11 @@ public IEnumerable<OnlineIssue> GetClosedIssues(DateTimeOffset? since)
             };
             return readOnlyList.Select(i => new OnlineIssue
             {
+                Id = "#" + i.Number.ToString(CultureInfo.InvariantCulture),
                 HtmlUrl = i.HtmlUrl,
-                Id = i.Number.ToString(CultureInfo.InvariantCulture),
+                Title = i.Title,
                 IssueType = i.PullRequest == null ? IssueType.Issue : IssueType.PullRequest,
                 Labels = i.Labels.Select(l => l.Name).ToArray(),
-                Title = i.Title,
                 DateClosed = i.ClosedAt.Value,
                 Contributors = i.PullRequest == null ? new Contributor[0] : new[] { new Contributor(getUserName(i.User), i.User.Login, i.User.HtmlUrl) }
             });

src/GitReleaseNotes/ReleaseNotesGenerator.cs

@@ -67,9 +67,9 @@ public string GenerateReleaseNotes(
                     var url = htmlUrl == null ? null : string.Format("({0})", htmlUrl);
                     var contributors = releaseNoteItem.Contributors == null || releaseNoteItem.Contributors.Length == 0 ?
                         string.Empty : " contributed by " + string.Join(", ", releaseNoteItem.Contributors.Select(r => string.Format("{0} ([{1}]({2}))", r.Name, r.Username, r.Url)));
-                    var item = string.Format("{4}{0}{1}{2}{5}{3}", title, issueNum, url, category,
+                    var item = string.Format(" - {1}{2}{4}{0}{5}{3}", title, issueNum, url, category,
                         title.TrimStart().StartsWith("-") ? null : " - ",
-                        contributors);
+                        contributors).Replace("  ", " ").Replace("- -", "-");
                     builder.AppendLine(item);
                 }