Fixed issue with shout outs

Author: Jake Ginnivan

NextVersion.txt

@@ -1 +1 @@
-0.2.0
+0.3.0

src/GitReleaseNotes.Tests/IssueTrackers/GitHub/GitHubIssueTrackerTests.cs

@@ -57,7 +57,7 @@ public void CreatesReleaseNotesForClosedGitHubIssues()
                         {
                             Login = "User",
                             Name = "Foo",
-                            Url = "http://github.com/foo"
+                            HtmlUrl = "http://github.com/foo"
                         }
                     }
                 }.AsReadOnly()));

src/GitReleaseNotes/IssueTrackers/GitHub/GitHubIssueTracker.cs

@@ -119,14 +119,29 @@ public IEnumerable<OnlineIssue> GetClosedIssues(DateTimeOffset? since)
             string repository;
             GetRepository(_arguments, out organisation, out repository);
 
-            var forRepository = _gitHubClientFactory().Issue.GetForRepository(organisation, repository, new RepositoryIssueRequest
+            var gitHubClient = _gitHubClientFactory();
+            var forRepository = gitHubClient.Issue.GetForRepository(organisation, repository, new RepositoryIssueRequest
             {
                 Filter = IssueFilter.All,
                 Since = since,
                 State = ItemState.Closed
             });
             var readOnlyList = forRepository.Result;
 
+            var userCache = new Dictionary<string, User>();
+            Func<User, string> getUserName = u =>
+            {
+                var login = u.Login;
+                if (!userCache.ContainsKey(login))
+                {
+                    userCache.Add(login, string.IsNullOrEmpty(u.Name) ? gitHubClient.User.Get(login).Result : u);
+                }
+
+                var user = userCache[login];
+                if (user != null) 
+                    return user.Name;
+                return null;
+            };
             return readOnlyList.Select(i => new OnlineIssue
             {
                 HtmlUrl = i.HtmlUrl,
@@ -135,7 +150,7 @@ public IEnumerable<OnlineIssue> GetClosedIssues(DateTimeOffset? since)
                 Labels = i.Labels.Select(l => l.Name).ToArray(),
                 Title = i.Title,
                 DateClosed = i.ClosedAt.Value,
-                Contributors = i.PullRequest == null ? new Contributor[0] : new[] { new Contributor(i.User.Name, i.User.Login, i.User.Url) }
+                Contributors = i.PullRequest == null ? new Contributor[0] : new[] { new Contributor(getUserName(i.User), i.User.Login, i.User.HtmlUrl) }
             });
         }
     }