Skip to content

Fix the import of descriptions from a shapefile for sensitive areas - #5642

Merged
PartyNell merged 1 commit into
masterfrom
fix_shapefile_sensitive_parsers
Aug 14, 2026
Merged

Fix the import of descriptions from a shapefile for sensitive areas#5642
PartyNell merged 1 commit into
masterfrom
fix_shapefile_sensitive_parsers

Conversation

@PartyNell

Copy link
Copy Markdown
Contributor

Description

To import descriptions the shapefile had to define a field "description" but it is impossible because there is more that 10 characteres. Then this PR remove the last n as for Reglementary areas.

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

AI requirements

Skip the checkboxes below 👇 If you didn't use AI for your contribution

  • I used AI assistance to produce part or all of this contribution
  • I have read, reviewed, understood and can explain the code I am submitting
  • I can explain and discuss my work to a maintainer
  • I pasted the prompt used and mentioned the model used below

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.53%. Comparing base (85802a3) to head (b2ab0d3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5642   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         274      274           
  Lines       23006    23006           
=======================================
  Hits        22670    22670           
  Misses        336      336           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress

cypress Bot commented Aug 14, 2026

Copy link
Copy Markdown

Geotrek-admin    Run #17631

Run Properties:  status check passed Passed #17631  •  git commit b16b5f919e ℹ️: Merge b2ab0d34722cd92d7d17a92140d10069c50b4fac into 85802a387276ec95d97c36707404...
Project Geotrek-admin
Branch Review refs/pull/5642/merge
Run status status check passed Passed #17631
Run duration 02m 10s
Commit git commit b16b5f919e ℹ️: Merge b2ab0d34722cd92d7d17a92140d10069c50b4fac into 85802a387276ec95d97c36707404...
Committer Nell Party
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@PartyNell
PartyNell merged commit e43b731 into master Aug 14, 2026
23 checks passed
@PartyNell
PartyNell deleted the fix_shapefile_sensitive_parsers branch August 14, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants