Skip to content

fix: move worker-config from values.yaml volumeMount to statefulset.yaml volumeMount#1527

Merged
shree-iyengar-dls merged 8 commits intomainfrom
1451_change_config_overwriteability
Apr 30, 2026
Merged

fix: move worker-config from values.yaml volumeMount to statefulset.yaml volumeMount#1527
shree-iyengar-dls merged 8 commits intomainfrom
1451_change_config_overwriteability

Conversation

@shree-iyengar-dls
Copy link
Copy Markdown
Contributor

Fixes #1451

Tested on p48:

  • created a new PVC which was referenced in the p48-blueapi-0 pod under volumes:
 name: my-pv-claim
    persistentVolumeClaim:
      claimName: my-pv-claim
  • The PV was also bound:
pvc-905772f8-0fe1-4d8d-8186-4838473eb289      1Gi        RWX            Delete           Bound       p48-beamline/my-pv-claim

@shree-iyengar-dls shree-iyengar-dls requested a review from a team as a code owner April 29, 2026 12:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.34%. Comparing base (d880320) to head (66da810).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1527   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files          43       43           
  Lines        3200     3200           
=======================================
  Hits         3051     3051           
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@dan-fernandes dan-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Very minor corrections

Comment thread helm/blueapi/values.yaml Outdated
# - ALL

# This is for setting up a service more information can be found here: https://kubernetes.io/docs/concepts/services-networking/service/
# This is for setting up a service more information can be found here: https://kubernetes.io/docs/concepts/services-networking/service/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here and on lines 79-85 and 208 have removed some useful documentation from the values.schema.json. Probably just you IDE autoformatting files.

Unindent to fix

Comment thread helm/blueapi/values.yaml
- name: worker-config
mountPath: "/config"
readOnly: true
volumeMounts: []
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a commented-out example of a volumeMount, as per extraEnvVars in the same file. That way people can see what to expect.

Comment thread helm/blueapi/values.yaml
repositories: []
# - name: "dodal"
# remote_url: https://github.com/DiamondLightSource/dodal.git
# -- Configures logging. Port 12231 is the `dodal` input on graylog which will be renamed `blueapi`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is now too unindented

@dan-fernandes dan-fernandes self-requested a review April 30, 2026 12:37
@shree-iyengar-dls shree-iyengar-dls merged commit 2735289 into main Apr 30, 2026
18 checks passed
@shree-iyengar-dls shree-iyengar-dls deleted the 1451_change_config_overwriteability branch April 30, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BlueAPI Config Mount Easily Overwriteable

2 participants