fix: move worker-config from values.yaml volumeMount to statefulset.yaml volumeMount#1527
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 43 43
Lines 3200 3200
=======================================
Hits 3051 3051
Misses 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dan-fernandes
left a comment
There was a problem hiding this comment.
Looks really good! Very minor corrections
| # - ALL | ||
|
|
||
| # This is for setting up a service more information can be found here: https://kubernetes.io/docs/concepts/services-networking/service/ | ||
| # This is for setting up a service more information can be found here: https://kubernetes.io/docs/concepts/services-networking/service/ |
There was a problem hiding this comment.
The indentation here and on lines 79-85 and 208 have removed some useful documentation from the values.schema.json. Probably just you IDE autoformatting files.
Unindent to fix
| - name: worker-config | ||
| mountPath: "/config" | ||
| readOnly: true | ||
| volumeMounts: [] |
There was a problem hiding this comment.
Could add a commented-out example of a volumeMount, as per extraEnvVars in the same file. That way people can see what to expect.
| repositories: [] | ||
| # - name: "dodal" | ||
| # remote_url: https://github.com/DiamondLightSource/dodal.git | ||
| # -- Configures logging. Port 12231 is the `dodal` input on graylog which will be renamed `blueapi` |
There was a problem hiding this comment.
This line is now too unindented
Fixes #1451
Tested on p48: