-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Add values json schema #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 40 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
d4784bb
Add script to export config schema, add to pre commit hook
dan-fernandes 38e6599
Change config_schema.json output location, add helm-schema to pre-commit
dan-fernandes 8b6b325
Add jsonschema
dan-fernandes bc35cae
Switch helm schema generator to helm-values-schema-generator
dan-fernandes fda27f6
Annotate worker with schema ref, remove additionalProperties
dan-fernandes 23e1d44
Add install helma-values-schema-json plugin as step in Dockerfile
dan-fernandes 4d1c83d
Add accidentally removed whitespace
dan-fernandes aa4efd7
Merge branch 'main' into add-values-json-schema
dan-fernandes 627b307
Add config-schema option to cli
dan-fernandes aa3e82a
Change pre commit to use blueapi config-schema rather than custom script
dan-fernandes 817fce3
Fix broken export-config-schema hook
dan-fernandes ec4948c
Add file dependencies to export-config-schema
dan-fernandes 5cdd60f
Add github action to install relevant helm plugin, invoke in _test.ym…
dan-fernandes ee81b59
Make config-schema pretty print to file
dan-fernandes 04d76a7
Add empty initResources object to inform schema
dan-fernandes 42eeea8
Update docstring
dan-fernandes df3b8a1
Fix export-config-schema regex (hopefully..)
dan-fernandes d12d18a
Update helm README.md
dan-fernandes e5a4181
Change helm-docs-container to helm-docs-built
dan-fernandes 4a09874
Merge branch 'fix-helm-docs-hook' into add-values-json-schema
dan-fernandes 085954c
Remove extra line at end of README.md
dan-fernandes 1bb6b87
Remove extra line at end of README.md
dan-fernandes c53086a
Exclude helm README.md from end-of-file-fixer
dan-fernandes 8642a45
Fix regex
dan-fernandes aabe8a1
Merge branch 'fix-helm-docs-hook' into add-values-json-schema
dan-fernandes 67c02d0
Regenerate README.md
dan-fernandes 3fed2cf
De-abstract installing helm plugins
dan-fernandes ced668e
Add test_config_schema_updated
dan-fernandes 89dbd27
Remove export-config-schema pre-commit hook
dan-fernandes 33fc7a3
Remove unused import
dan-fernandes dabb2f6
Add exact path to values.yaml
dan-fernandes 425ddae
Add fail message to test_config_schema_updated
dan-fernandes ccfa601
Merge branch 'main' into add-values-json-schema
dan-fernandes e135689
Refactor config_schema
dan-fernandes f62dc6a
Reword error message
dan-fernandes 2551548
Add test_config_schema
dan-fernandes 3f6319c
Merge branch 'main' into add-values-json-schema
dan-fernandes f5da1bd
Fix merge issue
dan-fernandes c9b5054
Remove test_config_schema reliance on config_schema.json
dan-fernandes bbf0dcb
Lint
dan-fernandes 92aa509
Update .pre-commit-config.yaml
dan-fernandes a422ed3
Remove comment
dan-fernandes ca37308
Remove unecessary DeepDiff use
dan-fernandes f097161
Refactor test_config_schema to remove dependency on deepdiff
dan-fernandes f12d433
Remove unused improt
dan-fernandes e8d9bc9
Remove default fields
dan-fernandes ab5e7cb
Update additional properties
dan-fernandes f194bfe
Update values.schema.json
dan-fernandes 1e47fcc
Update dev-requirements.txt
dan-fernandes 593305f
Remove editable packages from dev-requirements
dan-fernandes f85fdaa
Merge branch 'main' into add-values-json-schema
dan-fernandes 24d1dea
Remove duplicate requirements
dan-fernandes 1dbab6c
Update config_schema.json
dan-fernandes 1ddd98e
Remove helm plugin install from _test.yml
dan-fernandes 6f3b0eb
Merge commit '82a80c0fb821635578fe9e1122a49685149ac866' into add-valu…
DiamondJoseph 20a4ded
Pass required config through .schema.yaml
DiamondJoseph 3fdb002
Apply suggestions from code review
DiamondJoseph 541930c
Merge branch 'main' into add-values-json-schema
dan-fernandes c8f2c4d
Merge branch 'main' into add-values-json-schema
DiamondJoseph 9be1fd7
Merge branch 'main' into add-values-json-schema
dan-fernandes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # .schema.yaml | ||
|
dan-fernandes marked this conversation as resolved.
|
||
|
|
||
| values: | ||
| - values.yaml | ||
|
|
||
| draft: 2020 | ||
| indent: 4 | ||
| output: values.schema.json | ||
|
|
||
| bundle: true | ||
| bundleRoot: . | ||
| bundleWithoutID: false | ||
|
|
||
| useHelmDocs: false | ||
|
|
||
| noAdditionalProperties: false | ||
|
|
||
| schemaRoot: | ||
| id: https://example.com/schema | ||
| title: Helm Values Schema | ||
| description: Schema for Helm values | ||
| additionalProperties: false | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.