minor cleanups

Author: devshgraphicsprogramming

examples_tests

@@ -209,7 +209,7 @@ struct num_traits<float16_t> : num_base<float16_t>
 {
     // since float16_t has no constexpr ctor we have to use float32_t constants on cpp side which is only needed for testing
     using type = 
-#ifdef __cplusplus
+#ifndef __HLSL_VERSION
     float32_t
 #else
     float16_t

include/nbl/builtin/hlsl/limits.hlsl

@@ -21,6 +21,8 @@ struct PartitionRandVariable
     using floating_point_type = T;
     using uint_type = unsigned_integer_of_size_t<sizeof(floating_point_type)>;
 
+    // TODO: create method to apply `*NextULPAfterUnity`
+
     bool operator()(NBL_REF_ARG(floating_point_type) xi, NBL_REF_ARG(floating_point_type) rcpChoiceProb)
     {
         const floating_point_type NextULPAfterUnity = bit_cast<floating_point_type>(bit_cast<uint_type>(floating_point_type(1.0)) + uint_type(1u));
@@ -35,6 +37,7 @@ struct PartitionRandVariable
         return pickRight;
     }
 
+    // store with `* NextULPAfterUnity` already applied
     floating_point_type leftProb;
 };
 

include/nbl/builtin/hlsl/sampling/basic.hlsl

@@ -143,8 +143,8 @@ class IGPURayTracingPipeline :  public IGPUPipeline<asset::IRayTracingPipeline<c
 
         struct SShaderGroupHandle
         {
-          private:
-            uint8_t data[video::SPhysicalDeviceLimits::ShaderGroupHandleSize];
+            private:
+                uint8_t data[video::SPhysicalDeviceLimits::ShaderGroupHandleSize];
         };
         static_assert(sizeof(SShaderGroupHandle) == video::SPhysicalDeviceLimits::ShaderGroupHandleSize);
 

include/nbl/video/IGPURayTracingPipeline.h

@@ -1032,12 +1032,6 @@ bool ILogicalDevice::createRayTracingPipelines(IGPUPipelineCache* const pipeline
         const bool skipAABBs = bool(param.getFlags() & IGPURayTracingPipeline::SCreationParams::FLAGS::SKIP_AABBS);
         const bool skipBuiltin = bool(param.getFlags() & IGPURayTracingPipeline::SCreationParams::FLAGS::SKIP_BUILT_IN_PRIMITIVES);
 
-        if (!features.rayTracingPipeline)
-        {
-            NBL_LOG_ERROR("Raytracing Pipeline feature not enabled!");
-            return {};
-        }
-
         // https://docs.vulkan.org/spec/latest/chapters/pipelines.html#VUID-VkRayTracingPipelineCreateInfoKHR-rayTraversalPrimitiveCulling-03597
         if (skipAABBs && skipBuiltin)
         {